diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-25 16:45:48 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-26 00:20:05 +0900 |
| commit | 291b43d132749a61918dca23acef1b639c5333a7 (patch) | |
| tree | 7c21aea3d2940df0f97a506a1abe0701a09d912e | |
| parent | f5f429dbae0a3e2d8224c0b1e4edcef54805d286 (diff) | |
| download | php-shirabe-291b43d132749a61918dca23acef1b639c5333a7.tar.gz php-shirabe-291b43d132749a61918dca23acef1b639c5333a7.tar.zst php-shirabe-291b43d132749a61918dca23acef1b639c5333a7.zip | |
test: un-ignore 14 tests unblocked by CurlDownloader and regex fixes
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 files changed, 0 insertions, 14 deletions
diff --git a/crates/shirabe/tests/downloader/archive_downloader_test.rs b/crates/shirabe/tests/downloader/archive_downloader_test.rs index 8c65b08..3543c2e 100644 --- a/crates/shirabe/tests/downloader/archive_downloader_test.rs +++ b/crates/shirabe/tests/downloader/archive_downloader_test.rs @@ -54,7 +54,6 @@ fn get_archive_downloader(vendor_dir: Option<&str>) -> FileDownloader { } #[test] -#[ignore] fn test_get_file_name() { let package = get_package("dummy/pkg", "1.0.0"); package.set_dist_url(Some("http://example.com/script.js".to_string())); @@ -68,7 +67,6 @@ fn test_get_file_name() { } #[test] -#[ignore] fn test_process_url() { let downloader = get_archive_downloader(None); @@ -80,7 +78,6 @@ fn test_process_url() { } #[test] -#[ignore] fn test_process_url2() { let downloader = get_archive_downloader(None); @@ -92,7 +89,6 @@ fn test_process_url2() { } #[test] -#[ignore] fn test_process_url3() { let downloader = get_archive_downloader(None); diff --git a/crates/shirabe/tests/util/config_validator_test.rs b/crates/shirabe/tests/util/config_validator_test.rs index 4f25535..94e5792 100644 --- a/crates/shirabe/tests/util/config_validator_test.rs +++ b/crates/shirabe/tests/util/config_validator_test.rs @@ -59,7 +59,6 @@ fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { } #[test] -#[ignore] fn test_config_validator_warns_on_unnecessary_provide_replace() { let warnings = validate(&fixture("composer_provide-replace-requirements.json")); diff --git a/crates/shirabe/tests/util/git_test.rs b/crates/shirabe/tests/util/git_test.rs index 6d615c5..7e382b5 100644 --- a/crates/shirabe/tests/util/git_test.rs +++ b/crates/shirabe/tests/util/git_test.rs @@ -109,7 +109,6 @@ fn test_run_command_public_git_hub_repository_not_initial_clone_https() { } #[test] -#[ignore = "reaches Git::throw_exception -> Url::sanitize, whose preg pattern fails to parse in the regex crate (preg shim bug, unrelated to this test); production Url::sanitize must be fixed first"] fn test_run_command_private_git_hub_repository_not_initial_clone_not_interactive_without_authentication() { let command_callable: Box<dyn Fn(&str) -> Vec<String>> = Box::new(|url: &str| { @@ -269,7 +268,6 @@ fn run_command_private_bitbucket_with_authentication( } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_ssh_token() { run_command_private_bitbucket_with_authentication( @@ -282,7 +280,6 @@ fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interacti } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_https_token() { run_command_private_bitbucket_with_authentication( @@ -295,7 +292,6 @@ fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interacti } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_https_git_token() { run_command_private_bitbucket_with_authentication( @@ -320,7 +316,6 @@ fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interacti } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_https_no_token() { run_command_private_bitbucket_with_authentication( @@ -333,7 +328,6 @@ fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interacti } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_https_git_no_token() { run_command_private_bitbucket_with_authentication( @@ -346,7 +340,6 @@ fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interacti } #[test] -#[ignore = "after the first failing git command, Bitbucket::new constructs a real HttpDownloader -> CurlDownloader::new -> curl_multi_init(), which is todo!() in the curl shim; needs the curl shim or an injected HttpDownloader mock on Git"] fn test_run_command_private_bitbucket_repository_not_initial_clone_not_interactive_with_authentication_atat_token() { run_command_private_bitbucket_with_authentication( @@ -421,7 +414,6 @@ fn test_sync_mirror_sanitizes_url_after_initial_clone() { } #[test] -#[ignore = "the failed-update branch reaches Git::throw_exception -> Url::sanitize, whose preg pattern fails to parse in the regex crate (preg shim bug, unrelated to this test); production Url::sanitize must be fixed first"] fn test_sync_mirror_sanitizes_url_even_after_failed_update() { let dir = std::env::temp_dir().display().to_string(); diff --git a/crates/shirabe/tests/util/http_downloader_test.rs b/crates/shirabe/tests/util/http_downloader_test.rs index 5c34e19..59807a9 100644 --- a/crates/shirabe/tests/util/http_downloader_test.rs +++ b/crates/shirabe/tests/util/http_downloader_test.rs @@ -17,7 +17,6 @@ fn test_capture_authentication_params_from_url() { } #[test] -#[ignore] fn test_output_warnings() { let io: Rc<RefCell<BufferIO>> = Rc::new(RefCell::new( BufferIO::new(String::new(), VERBOSITY_NORMAL, None).unwrap(), |
