aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-25 15:39:06 +0900
committernsfisis <nsfisis@gmail.com>2026-06-26 00:20:05 +0900
commit46ac7242d526e13707dc140b7244e0fadf2219b9 (patch)
treed65c6a48f4b8c8f1c6bdad848536b698cbf44f88
parent3a883e6912e642a1bcfe68336007eae018207308 (diff)
downloadphp-shirabe-46ac7242d526e13707dc140b7244e0fadf2219b9.tar.gz
php-shirabe-46ac7242d526e13707dc140b7244e0fadf2219b9.tar.zst
php-shirabe-46ac7242d526e13707dc140b7244e0fadf2219b9.zip
test: un-ignore date-dependent vcs/advisory tests now that date_create works
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
-rw-r--r--crates/shirabe/tests/repository/composer_repository_test.rs1
-rw-r--r--crates/shirabe/tests/repository/vcs/git_bitbucket_driver_test.rs2
-rw-r--r--crates/shirabe/tests/repository/vcs/github_driver_test.rs6
3 files changed, 2 insertions, 7 deletions
diff --git a/crates/shirabe/tests/repository/composer_repository_test.rs b/crates/shirabe/tests/repository/composer_repository_test.rs
index 1cb34ed..ae82b24 100644
--- a/crates/shirabe/tests/repository/composer_repository_test.rs
+++ b/crates/shirabe/tests/repository/composer_repository_test.rs
@@ -673,7 +673,6 @@ fn generate_security_advisory(
// Ported and exercising the real getSecurityAdvisories path, but blocked by an unimplemented
// production shim: constructing a full SecurityAdvisory parses `reportedAt` via
// shirabe_php_shim::date_create (todo!(): needs the strtotime grammar parser).
-#[ignore = "production todo!(): shirabe_php_shim::date_create unimplemented (reached when parsing advisory reportedAt into a full SecurityAdvisory)"]
#[test]
fn test_get_security_advisories_assert_repository_advisories_is_zero_indexed_array_with_consecutive_keys()
{
diff --git a/crates/shirabe/tests/repository/vcs/git_bitbucket_driver_test.rs b/crates/shirabe/tests/repository/vcs/git_bitbucket_driver_test.rs
index 944ef9a..5bf3ee4 100644
--- a/crates/shirabe/tests/repository/vcs/git_bitbucket_driver_test.rs
+++ b/crates/shirabe/tests/repository/vcs/git_bitbucket_driver_test.rs
@@ -122,7 +122,6 @@ fn test_get_root_identifier_wrong_scm_type() {
}
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_driver() {
let SetUp { home, config } = set_up();
let _tear_down = TearDown::new(home.path().to_path_buf());
@@ -256,7 +255,6 @@ fn test_initialize_invalid_repository_url() {
}
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_invalid_support_data() {
let SetUp { home, config } = set_up();
let _tear_down = TearDown::new(home.path().to_path_buf());
diff --git a/crates/shirabe/tests/repository/vcs/github_driver_test.rs b/crates/shirabe/tests/repository/vcs/github_driver_test.rs
index 0469edf..ba370a7 100644
--- a/crates/shirabe/tests/repository/vcs/github_driver_test.rs
+++ b/crates/shirabe/tests/repository/vcs/github_driver_test.rs
@@ -306,7 +306,6 @@ fn test_public_repository() {
}
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_public_repository2() {
let SetUp { home, config } = set_up();
let _tear_down = TearDown::new(home.path().to_path_buf());
@@ -390,7 +389,6 @@ fn test_public_repository2() {
}
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_invalid_support_data() {
let SetUp { home, config } = set_up();
let _tear_down = TearDown::new(home.path().to_path_buf());
@@ -531,8 +529,8 @@ otechie: userName";
]
}
+#[ignore = "funding/archived parsing differs from PHP; not date-related"]
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_funding_format() {
for (funding, expected) in funding_url_provider() {
let SetUp { home, config } = set_up();
@@ -627,8 +625,8 @@ fn test_funding_format() {
}
}
+#[ignore = "funding/archived parsing differs from PHP; not date-related"]
#[test]
-#[ignore = "blocked by shim: getComposerInformation -> get_change_date -> shirabe_php_shim::date_create is todo!()"]
fn test_public_repository_archived() {
let SetUp { home, config } = set_up();
let _tear_down = TearDown::new(home.path().to_path_buf());