aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 07:00:08 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 07:28:42 +0900
commit63a77b1495944ad9707fe036a73f99eaec189897 (patch)
treeffc022b4e5f705080210f170235f59d86f4acbfc
parentd2205f05fa4a2c4fe02a904da587e8c2d9534015 (diff)
downloadphp-shirabe-63a77b1495944ad9707fe036a73f99eaec189897.tar.gz
php-shirabe-63a77b1495944ad9707fe036a73f99eaec189897.tar.zst
php-shirabe-63a77b1495944ad9707fe036a73f99eaec189897.zip
test(zip): detail why the zip-extension test stays ignored
PHP only runs this test when the zip extension is not loaded; the Rust port has unconditional zip support, so that precondition cannot exist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
-rw-r--r--crates/shirabe/tests/util/zip_test.rs6
1 files changed, 5 insertions, 1 deletions
diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs
index 0c7d96a1..e3e976de 100644
--- a/crates/shirabe/tests/util/zip_test.rs
+++ b/crates/shirabe/tests/util/zip_test.rs
@@ -11,8 +11,12 @@ fn fixture(name: &str) -> String {
)
}
+// TODO(phase-d): PHP runs this test only when the zip extension is NOT loaded (it is
+// markTestSkipped otherwise). The Rust port links zip support unconditionally, so the
+// "extension not loaded" precondition cannot exist and the expected RuntimeException
+// ("The Zip Util requires PHP's zip extension") is unreachable by design.
#[test]
-#[ignore = "skipped in PHP whenever the zip extension is loaded, which it always is here"]
+#[ignore = "requires a PHP runtime without the zip extension; the Rust port has unconditional zip support, so this precondition is impossible to reproduce"]
fn test_throws_exception_if_zip_extension_is_not_loaded() {
assert!(Zip::get_composer_json("").is_err());
}