aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/command/command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 11:04:17 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 11:04:17 +0900
commit2592062434eeb5fe814dbca953d5fd23458bc135 (patch)
tree050fc0b685ca80cd54a1e3ddb2965a3bef2cc593 /crates/shirabe-external-packages/src/symfony/console/command/command.rs
parentc241931303448f9449051ea2080c1b65561066f2 (diff)
downloadphp-shirabe-2592062434eeb5fe814dbca953d5fd23458bc135.tar.gz
php-shirabe-2592062434eeb5fe814dbca953d5fd23458bc135.tar.zst
php-shirabe-2592062434eeb5fe814dbca953d5fd23458bc135.zip
feat(symfony-console): implement the shell completion command plumbing
The _complete and completion commands were registered but always panicked: get_class_of_command / instantiate_completion_output / tail_debug_log were todo!() and the completion.bash resource was not shipped. - make Command::complete return anyhow::Result so completion errors propagate to CompleteCommand's catch-all (exit code 2) like PHP - add Command::get_class as the port hook for PHP's get_class() debug log; every command supplies its PHP FQCN via the delegation macro - embed Resources/completion.bash at compile time (single-binary port); get_supported_shells becomes a static list - implement tail_debug_log by moving the shared output handle into the 'static process callback - add OutputInterface::as_console_output so unsupported-shell errors go to stderr as in PHP - fix CompletionInput::bind to keep the argument name PHP assigns in the foreach head even when the loop breaks on the first unset argument; application-level completion always hit this and returned no suggestions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/command/command.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/command/command.rs29
1 files changed, 28 insertions, 1 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/command.rs b/crates/shirabe-external-packages/src/symfony/console/command/command.rs
index 6e6c2212..1f1455f8 100644
--- a/crates/shirabe-external-packages/src/symfony/console/command/command.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/command/command.rs
@@ -325,6 +325,13 @@ macro_rules! delegate_command_trait_impls_to_inner {
$crate::delegate_to_inner!($field, fn ignore_validation_errors(&self));
$crate::delegate_to_inner!($field, fn get_ignore_validation_errors(&self) -> bool);
};
+ // Variant taking the command's PHP fully-qualified class name (see `Command::get_class`).
+ ($field:ident, $fqcn:literal) => {
+ $crate::delegate_command_trait_impls_to_inner!($field);
+ fn get_class(&self) -> String {
+ $fqcn.to_string()
+ }
+ };
}
/// Polymorphic interface for all commands (PHP's `Command` base class as seen by
@@ -369,8 +376,24 @@ pub trait Command: std::fmt::Debug + shirabe_php_shim::AsAny {
Ok(())
}
+ /// The PHP fully-qualified class name of the concrete command. Port hook for PHP's
+ /// `\get_class($command)` (used by `CompleteCommand`'s debug log), which Rust cannot
+ /// reflect from a trait object; every concrete command supplies its FQCN, usually via
+ /// `delegate_command_trait_impls_to_inner!($field, "Fqcn")`.
+ fn get_class(&self) -> String;
+
/// Adds suggestions to `suggestions` for the current completion input.
- fn complete(&self, _input: &CompletionInput, _suggestions: &mut CompletionSuggestions) {}
+ ///
+ /// PHP's `complete` is `void` but can throw; errors are surfaced through `anyhow::Result`
+ /// so they propagate to `CompleteCommand::execute`'s catch-all (which turns them into
+ /// exit code 2), matching the PHP exception flow.
+ fn complete(
+ &self,
+ _input: &CompletionInput,
+ _suggestions: &mut CompletionSuggestions,
+ ) -> anyhow::Result<()> {
+ Ok(())
+ }
/// Whether this command proxies to another application/command (Composer's
/// `BaseCommand::isProxyCommand`). Exposed here so the `dyn Command` registry can detect proxy
@@ -553,6 +576,10 @@ impl Command for CommandData {
true
}
+ fn get_class(&self) -> String {
+ panic!("get_class called on the base command state; concrete commands supply their FQCN");
+ }
+
fn set_application(
&self,
application: Option<std::rc::Rc<std::cell::RefCell<dyn Application>>>,