diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:27:36 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:29:08 +0900 |
| commit | 9efc866ae2553a9c51abae7214f62dde4f5f053c (patch) | |
| tree | d3749ced8b4e32713d4f5e3e88a34b501c4b4918 /crates/shirabe-external-packages/src/symfony/console/command/command.rs | |
| parent | 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (diff) | |
| download | php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.gz php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.zst php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.zip | |
chore(todo): consolidate TODO comments into the five fixed marker tags
Retag every Shirabe-authored TODO comment to one of the fixed tags:
phase-c, phase-d, plugin, php-runtime, phase-e.
Upstream-authored TODO comments from Composer/Symfony are left
untouched to preserve the ported code shape.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/command/command.rs')
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/command/command.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/command.rs b/crates/shirabe-external-packages/src/symfony/console/command/command.rs index 2af60db0..f9808878 100644 --- a/crates/shirabe-external-packages/src/symfony/console/command/command.rs +++ b/crates/shirabe-external-packages/src/symfony/console/command/command.rs @@ -61,7 +61,7 @@ impl CommandData { pub const DEFAULT_DESCRIPTION: Option<&'static str> = None; pub fn get_default_name() -> Option<String> { - // TODO(review): PHP uses ReflectionClass to read the #[AsCommand] attribute + // TODO(phase-c): PHP uses ReflectionClass to read the #[AsCommand] attribute // and ReflectionProperty to check that `$defaultName` is declared on the late-static // class itself (not inherited). Reflection-based late static binding cannot be // reproduced in Phase A; human review needed for the porting strategy. @@ -69,7 +69,7 @@ impl CommandData { } pub fn get_default_description() -> Option<String> { - // TODO(review): same Reflection/late-static-binding concern as get_default_name(). + // TODO(phase-c): same Reflection/late-static-binding concern as get_default_name(). todo!() } @@ -429,7 +429,7 @@ pub trait Command: std::fmt::Debug + shirabe_php_shim::AsAny + shirabe_php_shim: self.initialize(input.clone(), output.clone())?; if let Some(process_title) = self.get_process_title() { - // TODO: PHP probes for cli_set_process_title / setproctitle availability. + // TODO(phase-c): PHP probes for cli_set_process_title / setproctitle availability. if shirabe_php_shim::function_exists("cli_set_process_title") { if !shirabe_php_shim::cli_set_process_title(&process_title) { if shirabe_php_shim::PHP_OS == "Darwin" { @@ -874,7 +874,7 @@ impl Command for CommandData { &self, code: Box<dyn Fn(&mut dyn InputInterface, &mut dyn OutputInterface) -> PhpMixed>, ) { - // TODO: PHP rebinds an unbound Closure's $this to the command instance via + // TODO(php-runtime): PHP rebinds an unbound Closure's $this to the command instance via // ReflectionFunction/Closure::bind. Rust closures have no `$this` rebinding; // the closure is stored as-is. *self.code.borrow_mut() = Some(code); |
