diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:16:51 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:16:51 +0900 |
| commit | 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (patch) | |
| tree | e0fc935abf0cebb2c557581fbfd098bdef35d558 /crates/shirabe-external-packages/src/symfony/console/command/help_command.rs | |
| parent | 4361059d3bb27916179acfebb8889f1863319bb9 (diff) | |
| download | php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.gz php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.zst php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.zip | |
refactor(php-shim): introduce PhpClass for reporting PHP class names
Rust has no runtime class name, so `Command::get_class` existed purely to
let each command hand back its PHP class name, supplied through the
two-argument variant of `delegate_command_trait_impls_to_inner!` at the
impl site. Replace it with a general `PhpClass` trait plus an
`impl_php_class!` macro, so the name is stated once next to the type
definition and the mechanism is reusable outside commands.
`Command` gains `PhpClass` as a supertrait and drops `get_class`, and
`VcsDriverKind`'s hand-rolled `php_class_name` table moves onto the trait.
Behavior is unchanged: the same class-name strings are reported, and the
base command state still panics when asked for a name it cannot supply.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/command/help_command.rs')
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/command/help_command.rs | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/help_command.rs b/crates/shirabe-external-packages/src/symfony/console/command/help_command.rs index 83ed4f5b..d7a88422 100644 --- a/crates/shirabe-external-packages/src/symfony/console/command/help_command.rs +++ b/crates/shirabe-external-packages/src/symfony/console/command/help_command.rs @@ -13,7 +13,7 @@ use crate::symfony::console::input::input_definition::DefinitionItem; use crate::symfony::console::input::input_interface::InputInterface; use crate::symfony::console::input::input_option::InputOption; use crate::symfony::console::output::output_interface::OutputInterface; -use shirabe_php_shim::PhpMixed; +use shirabe_php_shim::{PhpMixed, impl_php_class}; use std::ops::{Deref, DerefMut}; /// HelpCommand displays the help for a given command. @@ -23,6 +23,11 @@ pub struct HelpCommand { command: std::cell::RefCell<Option<std::rc::Rc<std::cell::RefCell<dyn Command>>>>, } +impl_php_class!( + HelpCommand, + r"Symfony\Component\Console\Command\HelpCommand" +); + impl Deref for HelpCommand { type Target = CommandData; @@ -164,8 +169,5 @@ impl Command for HelpCommand { Ok(()) } - crate::delegate_command_trait_impls_to_inner!( - inner, - "Symfony\\Component\\Console\\Command\\HelpCommand" - ); + crate::delegate_command_trait_impls_to_inner!(inner); } |
