diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-24 04:16:08 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-24 04:16:08 +0900 |
| commit | e87d37a294a4c754585309d391d793a2c9a1287e (patch) | |
| tree | cc9ebf30f30355be0545a02462162c534516ca8b /crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs | |
| parent | f1af14b1cc503ac20f56a79a96c7780d02bdfe75 (diff) | |
| download | php-shirabe-e87d37a294a4c754585309d391d793a2c9a1287e.tar.gz php-shirabe-e87d37a294a4c754585309d391d793a2c9a1287e.tar.zst php-shirabe-e87d37a294a4c754585309d391d793a2c9a1287e.zip | |
feat(console): implement application description for `list`
Replace the todo!() in TextDescriptor::describe_application with a real
option-only InputDefinition built via InputDefinition::from_options,
which shares InputOption behind Rc instead of reconstructing by value.
Drop the now-unused Command::clone_box and switch the descriptors to
borrow the shared commands directly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs')
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs index b0c0090..afb7ca8 100644 --- a/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs +++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs @@ -308,11 +308,14 @@ impl TextDescriptor { self.write_text("<comment>Usage:</comment>\n", &options); self.write_text(" command [options] [arguments]\n\n", &options); - // PHP: new InputDefinition($application->getDefinition()->getOptions()). - // `InputOption` is not Clone and lives behind `Rc`, so the option-only - // definition cannot be reconstructed by value yet. - let definition: InputDefinition = - todo!("new InputDefinition($application->getDefinition()->getOptions())"); + let app_definition = application.borrow_mut().get_definition(); + let options_only: Vec<std::rc::Rc<InputOption>> = app_definition + .borrow() + .get_options() + .values() + .cloned() + .collect(); + let definition = InputDefinition::from_options(options_only)?; self.describe_input_definition(&definition, options.clone())?; self.write_text("\n", &IndexMap::new()); |
