refactor: fix compiler warnings and clippy warnings

2 files changed, 8 insertions, 13 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs
index 4961bd8..8e54d9e 100644
--- a/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/text_descriptor.rs
@@ -62,7 +62,7 @@ impl TextDescriptor {
         self.write_text(
             &format!(
                 "  <info>{}</info>  {}{}{}",
-                argument.get_name().to_string(),
+                argument.get_name(),
                 shirabe_php_shim::str_repeat(" ", spacing_width as usize),
                 // + 4 = 2 spaces before <info>, 2 spaces after </info>
                 Preg::replace(
@@ -114,14 +114,14 @@ impl TextDescriptor {
         let synopsis = format!(
             "{}{}",
             if option.get_shortcut().is_some() {
-                format!("-{}, ", option.get_shortcut().unwrap().to_string())
+                format!("-{}, ", option.get_shortcut().unwrap())
             } else {
                 "    ".to_string()
             },
             if option.is_negatable() {
                 format!("--{0}|--no-{0}", option.get_name().to_string())
             } else {
-                format!("--{0}{1}", option.get_name().to_string(), value.clone())
+                format!("--{0}{1}", option.get_name(), value.clone())
             }
         );
 
@@ -400,10 +400,11 @@ impl TextDescriptor {
                     };
                     self.write_text(
                         &format!(
-                            "  <info>{}</info>{}{}",
+                            "  <info>{}</info>{}{}{}",
                             name.clone(),
                             shirabe_php_shim::str_repeat(" ", spacing_width as usize),
-                            format!("{}{}", command_aliases, command.get_description()),
+                            command_aliases,
+                            command.get_description(),
                         ),
                         &options,
                     );
diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/xml_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/xml_descriptor.rs
index 77fca93..c2770a4 100644
--- a/crates/shirabe-external-packages/src/symfony/console/descriptor/xml_descriptor.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/xml_descriptor.rs
@@ -336,14 +336,8 @@ impl XmlDescriptor {
     /// getInputOptionDocument when the default is an array (returns it verbatim).
     fn default_values_as_strings(&self, default: &PhpMixed) -> Vec<String> {
         match default {
-            PhpMixed::List(list) => list
-                .iter()
-                .map(|v| shirabe_php_shim::php_to_string(v))
-                .collect(),
-            PhpMixed::Array(arr) => arr
-                .values()
-                .map(|v| shirabe_php_shim::php_to_string(v))
-                .collect(),
+            PhpMixed::List(list) => list.iter().map(shirabe_php_shim::php_to_string).collect(),
+            PhpMixed::Array(arr) => arr.values().map(shirabe_php_shim::php_to_string).collect(),
             _ => vec![],
         }
     }