refactor(php-shim): replace literal sprintf calls with format!

Convert every sprintf() call with a compile-time literal format string to
format!, implementing Display for PhpMixed (delegating to php_to_string) so
PhpMixed values render with PHP string semantics through {}. Also merge the
format!-wrapped and conditional-literal dynamic sites into single format!
calls. Genuinely runtime format strings (table styles, configurable error
messages, command synopsis, progress-bar modifiers, regex-built messages)
still go through sprintf.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 6 insertions, 14 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
index 6f52458..5189efd 100644
--- a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs
@@ -119,10 +119,7 @@ impl Table {
 
         Ok(Err(InvalidArgumentException(
             shirabe_php_shim::InvalidArgumentException {
-                message: shirabe_php_shim::sprintf(
-                    "Style \"%s\" is not defined.",
-                    &[PhpMixed::from(name)],
-                ),
+                message: format!("Style \"{}\" is not defined.", PhpMixed::from(name),),
                 code: 0,
             },
         )))
@@ -271,12 +268,10 @@ impl Table {
     ) -> anyhow::Result<Result<&mut Self, RuntimeException>> {
         if !Self::output_is_console_section(&self.output) {
             return Ok(Err(RuntimeException(shirabe_php_shim::RuntimeException {
-                message: shirabe_php_shim::sprintf(
-                    "Output should be an instance of \"%s\" when calling \"%s\".",
-                    &[
-                        PhpMixed::from("Symfony\\Component\\Console\\Output\\ConsoleSectionOutput"),
-                        PhpMixed::from("Symfony\\Component\\Console\\Helper\\Table::appendRow"),
-                    ],
+                message: format!(
+                    "Output should be an instance of \"{}\" when calling \"{}\".",
+                    PhpMixed::from("Symfony\\Component\\Console\\Output\\ConsoleSectionOutput"),
+                    PhpMixed::from("Symfony\\Component\\Console\\Helper\\Table::appendRow"),
                 ),
                 code: 0,
             })));
@@ -1239,10 +1234,7 @@ impl Table {
 
         Ok(Err(InvalidArgumentException(
             shirabe_php_shim::InvalidArgumentException {
-                message: shirabe_php_shim::sprintf(
-                    "Style \"%s\" is not defined.",
-                    &[PhpMixed::from(name_str)],
-                ),
+                message: format!("Style \"{}\" is not defined.", PhpMixed::from(name_str),),
                 code: 0,
             },
         )))