refactor(pcre): treat regex compile failure as fatal in shim

The preg_* shim helpers wrapped their results in Option/Result solely to
signal a regex that failed to compile. Composer never feeds a pattern
that fails at runtime, so such a failure is a programming error: panic
instead and drop the Option/Result wrappers, updating all callers.

preg_replace_callback keeps its Result return type since the callback
itself is fallible. preg_match_groups is removed in favor of preg_match
at its sole call site.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 7 insertions, 2 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/input/argv_input.rs b/crates/shirabe-external-packages/src/symfony/console/input/argv_input.rs
index ea36e26..2b1102c 100644
--- a/crates/shirabe-external-packages/src/symfony/console/input/argv_input.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/input/argv_input.rs
@@ -528,8 +528,13 @@ impl ArgvInput {
             .tokens
             .iter()
             .map(|token| {
-                if let Some(m) = shirabe_php_shim::preg_match_groups("{^(-[^=]+=)(.+)}", token) {
-                    return format!("{}{}", m[1], self.inner.escape_token(&m[2]));
+                let mut r#match: Vec<Option<String>> = Vec::new();
+                if shirabe_php_shim::preg_match("{^(-[^=]+=)(.+)}", token, &mut r#match) != 0 {
+                    return format!(
+                        "{}{}",
+                        r#match[1].as_deref().unwrap_or(""),
+                        self.inner.escape_token(r#match[2].as_deref().unwrap_or(""))
+                    );
                 }
 
                 if !token.is_empty() && token.as_bytes()[0] != b'-' {