refactor(php-shim): replace literal sprintf calls with format!

Convert every sprintf() call with a compile-time literal format string to
format!, implementing Display for PhpMixed (delegating to php_to_string) so
PhpMixed values render with PHP string semantics through {}. Also merge the
format!-wrapped and conditional-literal dynamic sites into single format!
calls. Genuinely runtime format strings (table styles, configurable error
messages, command synopsis, progress-bar modifiers, regex-built messages)
still go through sprintf.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 10 insertions, 13 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/input/array_input.rs b/crates/shirabe-external-packages/src/symfony/console/input/array_input.rs
index 17c8aa8..ccc1916 100644
--- a/crates/shirabe-external-packages/src/symfony/console/input/array_input.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/input/array_input.rs
@@ -206,9 +206,9 @@ impl ArrayInput {
         if !self.inner.definition.has_shortcut(shortcut) {
             return Err(InvalidOptionException(InvalidArgumentException(
                 shirabe_php_shim::InvalidArgumentException {
-                    message: shirabe_php_shim::sprintf(
-                        "The \"-%s\" option does not exist.",
-                        &[PhpMixed::String(shortcut.to_string())],
+                    message: format!(
+                        "The \"-{}\" option does not exist.",
+                        PhpMixed::String(shortcut.to_string()),
                     ),
                     code: 0,
                 },
@@ -233,9 +233,9 @@ impl ArrayInput {
             if !self.inner.definition.has_negation(name) {
                 return Err(InvalidOptionException(InvalidArgumentException(
                     shirabe_php_shim::InvalidArgumentException {
-                        message: shirabe_php_shim::sprintf(
-                            "The \"--%s\" option does not exist.",
-                            &[PhpMixed::String(name.to_string())],
+                        message: format!(
+                            "The \"--{}\" option does not exist.",
+                            PhpMixed::String(name.to_string()),
                         ),
                         code: 0,
                     },
@@ -257,9 +257,9 @@ impl ArrayInput {
             if option.is_value_required() {
                 return Err(InvalidOptionException(InvalidArgumentException(
                     shirabe_php_shim::InvalidArgumentException {
-                        message: shirabe_php_shim::sprintf(
-                            "The \"--%s\" option requires a value.",
-                            &[PhpMixed::String(name.to_string())],
+                        message: format!(
+                            "The \"--{}\" option requires a value.",
+                            PhpMixed::String(name.to_string()),
                         ),
                         code: 0,
                     },
@@ -282,10 +282,7 @@ impl ArrayInput {
         if !self.inner.definition.has_argument(name) {
             return Err(
                 InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
-                    message: shirabe_php_shim::sprintf(
-                        "The \"%s\" argument does not exist.",
-                        &[name.clone()],
-                    ),
+                    message: format!("The \"{}\" argument does not exist.", name.clone(),),
                     code: 0,
                 })
                 .into(),