aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 16:27:36 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 16:29:08 +0900
commit9efc866ae2553a9c51abae7214f62dde4f5f053c (patch)
treed3749ced8b4e32713d4f5e3e88a34b501c4b4918 /crates/shirabe-external-packages/src/symfony/string/unicode_string.rs
parent6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (diff)
downloadphp-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.gz
php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.zst
php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.zip
chore(todo): consolidate TODO comments into the five fixed marker tags
Retag every Shirabe-authored TODO comment to one of the fixed tags: phase-c, phase-d, plugin, php-runtime, phase-e. Upstream-authored TODO comments from Composer/Symfony are left untouched to preserve the ported code shape. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/string/unicode_string.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/string/unicode_string.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs b/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs
index e4158466..9048f77b 100644
--- a/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs
+++ b/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs
@@ -34,7 +34,7 @@ impl UnicodeString {
width
}
- // TODO(phase-d): the faithful `length()` uses `grapheme_strlen` (extended grapheme clusters),
+ // TODO(phase-c): the faithful `length()` uses `grapheme_strlen` (extended grapheme clusters),
// which needs Unicode segmentation tables with no Rust std equivalent and no permitted crate.
// Approximated with the code-point count, exact only when no combining/multi-code-point
// clusters are present (e.g. ASCII).
@@ -42,7 +42,7 @@ impl UnicodeString {
shirabe_php_shim::mb_strlen(&self.string, "UTF-8")
}
- // TODO(phase-d): the faithful `slice()` uses `grapheme_substr` (grapheme-cluster offsets), which
+ // TODO(phase-c): the faithful `slice()` uses `grapheme_substr` (grapheme-cluster offsets), which
// needs Unicode segmentation tables with no std equivalent and no permitted crate. Approximated
// with code-point offsets via `mb_substr`, exact only without combining/multi-code-point clusters.
pub fn slice(&self, start: i64, length: Option<i64>) -> Self {