aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-php-shim/src/array.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-25 15:12:06 +0900
committernsfisis <nsfisis@gmail.com>2026-06-26 00:20:05 +0900
commit8117e5450693d19726da877bce8aacf5c7aa53af (patch)
tree4b06e6f6924599f3402d29cdcdeb0f8a88354d89 /crates/shirabe-php-shim/src/array.rs
parent8dd3d67884a204ca40e3364206868fea77a312be (diff)
downloadphp-shirabe-8117e5450693d19726da877bce8aacf5c7aa53af.tar.gz
php-shirabe-8117e5450693d19726da877bce8aacf5c7aa53af.tar.zst
php-shirabe-8117e5450693d19726da877bce8aacf5c7aa53af.zip
test: port 44 vcs/downloader/version tests using mock infra
Port git, version_guesser, gitlab_driver, github_driver, and git_downloader tests using the ProcessExecutor/HttpDownloader mocks and IO/Config stubs. Fix production regex-porting bugs surfaced by the now-reachable paths: Url::sanitize and Response::find_header_value had non-delimited PCRE patterns; implement array_search_mixed non-strict branch and a datetime format mapping. Add HttpDownloader::__new_mock so mocked downloaders skip curl construction. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-php-shim/src/array.rs')
-rw-r--r--crates/shirabe-php-shim/src/array.rs17
1 files changed, 9 insertions, 8 deletions
diff --git a/crates/shirabe-php-shim/src/array.rs b/crates/shirabe-php-shim/src/array.rs
index 280ec64..ace6a72 100644
--- a/crates/shirabe-php-shim/src/array.rs
+++ b/crates/shirabe-php-shim/src/array.rs
@@ -233,20 +233,21 @@ pub fn array_search_mixed(
haystack: &PhpMixed,
strict: bool,
) -> Option<PhpMixed> {
- if !strict {
- // TODO(phase-c): non-strict array_search needs PHP's loose `==` comparison
- // semantics. Only the strict path is implemented; loose comparison is
- // deferred rather than approximated.
- todo!("non-strict array_search (PHP loose comparison)");
- }
+ let matches = |value: &PhpMixed| -> bool {
+ if strict {
+ value == needle
+ } else {
+ loose_eq(value, needle)
+ }
+ };
match haystack {
PhpMixed::List(items) => items
.iter()
- .position(|value| value == needle)
+ .position(matches)
.map(|i| PhpMixed::Int(i as i64)),
PhpMixed::Array(map) => map
.iter()
- .find(|(_, value)| *value == needle)
+ .find(|(_, value)| matches(value))
.map(|(key, _)| php_key_to_mixed(key)),
_ => None,
}