diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:27:36 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:29:08 +0900 |
| commit | 9efc866ae2553a9c51abae7214f62dde4f5f053c (patch) | |
| tree | d3749ced8b4e32713d4f5e3e88a34b501c4b4918 /crates/shirabe-php-shim/src/env.rs | |
| parent | 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (diff) | |
| download | php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.gz php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.zst php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.zip | |
chore(todo): consolidate TODO comments into the five fixed marker tags
Retag every Shirabe-authored TODO comment to one of the fixed tags:
phase-c, phase-d, plugin, php-runtime, phase-e.
Upstream-authored TODO comments from Composer/Symfony are left
untouched to preserve the ported code shape.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-php-shim/src/env.rs')
| -rw-r--r-- | crates/shirabe-php-shim/src/env.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe-php-shim/src/env.rs b/crates/shirabe-php-shim/src/env.rs index 9043167b..d84a8ad9 100644 --- a/crates/shirabe-php-shim/src/env.rs +++ b/crates/shirabe-php-shim/src/env.rs @@ -14,7 +14,7 @@ pub fn getenv<K: AsRef<std::ffi::OsStr>>(key: K) -> Option<std::ffi::OsString> { /// thread is concurrently reading or writing the process environment for the /// duration of this call. pub unsafe fn putenv<K: AsRef<std::ffi::OsStr>, V: AsRef<std::ffi::OsStr>>(key: K, value: V) { - // TODO: validate key and value format to avoid panic? + // TODO(phase-c): validate key and value format to avoid panic? unsafe { std::env::set_var(key, value) } } @@ -24,7 +24,7 @@ pub unsafe fn putenv<K: AsRef<std::ffi::OsStr>, V: AsRef<std::ffi::OsStr>>(key: /// thread is concurrently reading or writing the process environment for the /// duration of this call. pub unsafe fn putenv_clear<K: AsRef<std::ffi::OsStr>>(key: K) { - // TODO: validate key and value format to avoid panic? + // TODO(phase-c): validate key and value format to avoid panic? unsafe { std::env::remove_var(key) } } |