aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/advisory
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-08 01:54:56 +0900
committernsfisis <nsfisis@gmail.com>2026-06-08 01:54:56 +0900
commit318ea948f5932dfa7942081a269d62fd7161a9bf (patch)
tree0fff2fe818f87a20dea89a51901f9e16071f2f53 /crates/shirabe/src/advisory
parentf232d7f9d2936ef84bd904cacd21c12cb7012b34 (diff)
downloadphp-shirabe-318ea948f5932dfa7942081a269d62fd7161a9bf.tar.gz
php-shirabe-318ea948f5932dfa7942081a269d62fd7161a9bf.tar.zst
php-shirabe-318ea948f5932dfa7942081a269d62fd7161a9bf.zip
feat(phase-c): resolve reflection/downcast phase-b TODOs
Resolve category F phase-b TODOs (class-string, instanceof, get_class, method_exists, __FILE__, Reflection API, downcast). - VcsRepository: dispatch drivers through a VcsDriverKind enum (instantiate/supports/php_class_name) and add constructors to the concrete VCS drivers - repository downcasts via RepositoryInterfaceHandle::downcast_rc and as_any (init/show commands, vcs ValidatingArrayLoader) - BaseCommand::is_self_update_command override replaces an instanceof - Factory::create narrows PartialComposer to ComposerHandle via as_full - InstalledVersions gains set_self_dir/set_installed_is_local_dir, replacing Reflection-based static property mutation - ClassLoader::as_array_iter ports the PHP (array) cast - drop the unnecessary __FILE__ phar branch in self-update application get_class(command) reclassified TODO(plugin); buffer_io StreamableInputInterface downcast and the ValidatingArrayLoader trait redesign left as tracked TODOs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/advisory')
-rw-r--r--crates/shirabe/src/advisory/auditor.rs13
1 files changed, 2 insertions, 11 deletions
diff --git a/crates/shirabe/src/advisory/auditor.rs b/crates/shirabe/src/advisory/auditor.rs
index 258099d..2fc93f3 100644
--- a/crates/shirabe/src/advisory/auditor.rs
+++ b/crates/shirabe/src/advisory/auditor.rs
@@ -586,7 +586,7 @@ impl Auditor {
io.write_error(&sprintf(
"%s is abandoned. %s.",
&[
- PhpMixed::String(self.get_package_name_with_link_for_complete(pkg.clone())),
+ PhpMixed::String(self.get_package_name_with_link(pkg.clone().into())),
PhpMixed::String(replacement),
],
));
@@ -625,7 +625,7 @@ impl Auditor {
table.add_row(ConsoleIO::sanitize(
PhpMixed::List(vec![
Box::new(PhpMixed::String(
- self.get_package_name_with_link_for_complete(pkg.clone()),
+ self.get_package_name_with_link(pkg.clone().into()),
)),
Box::new(PhpMixed::String(replacement)),
]),
@@ -652,15 +652,6 @@ impl Auditor {
}
}
- // TODO(phase-b): merge with get_package_name_with_link once CompletePackageInterface can be
- // upcast to PackageInterface (e.g. via an as_package_interface() trait method)
- fn get_package_name_with_link_for_complete(
- &self,
- package: CompletePackageInterfaceHandle,
- ) -> String {
- self.get_package_name_with_link(package.into())
- }
-
fn get_severity(&self, advisory: &SecurityAdvisory) -> String {
if advisory.severity.is_none() {
return String::new();