aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/archive_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-19 18:47:48 +0900
committernsfisis <nsfisis@gmail.com>2026-07-19 18:47:48 +0900
commitfe0352e2db35ed559506c2b477708180768000e8 (patch)
treeefd3a985b33024914541eaab0bc44de41798a6e7 /crates/shirabe/src/command/archive_command.rs
parentd0cd98cd212bc13cbcfd0fd97fc245329b57f50f (diff)
downloadphp-shirabe-fe0352e2db35ed559506c2b477708180768000e8.tar.gz
php-shirabe-fe0352e2db35ed559506c2b477708180768000e8.tar.zst
php-shirabe-fe0352e2db35ed559506c2b477708180768000e8.zip
fix(show-command): un-ignore 10 tests by fixing show-warnings typing and repo bugs
Replace the PhpMixed-based `$showWarnings` hack in VersionSelector:: findBestCandidate with a typed ShowWarnings enum (Always / Predicate), letting ShowCommand::findLatestPackage pass its real closure instead of hardcoding `true`. Fix the --no-dev branch in ShowCommand::execute, which built `repos` from an empty package list instead of sharing the same InstalledRepository as `installed_repo`. Pass repository handles instead of pre-borrowed `&dyn RepositoryInterface` refs into get_package/ generate_package_tree/add_tree to stop a RefCell double-borrow panic on --all/--locked. Add the missing CompletePackage/RootPackage set_release_date setter so the outdated sorting-by-age test can set fixture dates. Resolve OutputFormatterStyleStack::pop's empty-style todo!() via clone_box(), and fix FileDownloader's cache-GC log call to pass the VERY_VERBOSE verbosity PHP uses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/archive_command.rs')
-rw-r--r--crates/shirabe/src/command/archive_command.rs3
1 files changed, 2 insertions, 1 deletions
diff --git a/crates/shirabe/src/command/archive_command.rs b/crates/shirabe/src/command/archive_command.rs
index cd2d1648..25d32b2b 100644
--- a/crates/shirabe/src/command/archive_command.rs
+++ b/crates/shirabe/src/command/archive_command.rs
@@ -12,6 +12,7 @@ use crate::io::IOInterfaceImmutable;
use crate::package::archiver::ArchiveManagerInterface;
use crate::package::version::VersionParser;
use crate::package::version::VersionSelector;
+use crate::package::version::version_selector::ShowWarnings;
use crate::plugin::CommandEvent;
use crate::plugin::PluginEvents;
use crate::repository::CompositeRepository;
@@ -424,7 +425,7 @@ impl ArchiveCommand {
None,
0,
None,
- shirabe_php_shim::PhpMixed::Bool(true),
+ ShowWarnings::Always,
)?;
let p = best.unwrap_or_else(|| packages.into_iter().next().unwrap());