aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/base_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 16:16:51 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 16:16:51 +0900
commit6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (patch)
treee0fc935abf0cebb2c557581fbfd098bdef35d558 /crates/shirabe/src/command/base_command.rs
parent4361059d3bb27916179acfebb8889f1863319bb9 (diff)
downloadphp-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.gz
php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.zst
php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.zip
refactor(php-shim): introduce PhpClass for reporting PHP class names
Rust has no runtime class name, so `Command::get_class` existed purely to let each command hand back its PHP class name, supplied through the two-argument variant of `delegate_command_trait_impls_to_inner!` at the impl site. Replace it with a general `PhpClass` trait plus an `impl_php_class!` macro, so the name is stated once next to the type definition and the mechanism is reusable outside commands. `Command` gains `PhpClass` as a supertrait and drops `get_class`, and `VcsDriverKind`'s hand-rolled `php_class_name` table moves onto the trait. Behavior is unchanged: the same class-name strings are reported, and the base command state still panics when asked for a name it cannot supply. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/base_command.rs')
-rw-r--r--crates/shirabe/src/command/base_command.rs14
1 files changed, 8 insertions, 6 deletions
diff --git a/crates/shirabe/src/command/base_command.rs b/crates/shirabe/src/command/base_command.rs
index 7e8a3f5a..77850e9e 100644
--- a/crates/shirabe/src/command/base_command.rs
+++ b/crates/shirabe/src/command/base_command.rs
@@ -27,8 +27,8 @@ use shirabe_external_packages::symfony::console::helper::TableSeparator;
use shirabe_external_packages::symfony::console::input::InputInterface;
use shirabe_external_packages::symfony::console::output::OutputInterface;
use shirabe_php_shim::{
- InvalidArgumentException, LogicException, PhpMixed, RuntimeException, UnexpectedValueException,
- count, explode, in_array, is_string,
+ InvalidArgumentException, LogicException, PhpClass, PhpMixed, RuntimeException,
+ UnexpectedValueException, count, explode, in_array, is_string,
};
pub const SUCCESS: i64 = 0;
@@ -280,11 +280,13 @@ macro_rules! delegate_base_command_trait_impls_to_inner {
impl Command for BaseCommandData {
shirabe_external_packages::delegate_command_trait_impls_to_inner!(inner);
+}
- fn get_class(&self) -> String {
- // Forwards to the base state's panicking get_class; concrete commands supply their
- // FQCN through delegate_command_trait_impls_to_inner!'s two-argument variant.
- self.inner.get_class()
+impl PhpClass for BaseCommandData {
+ fn php_class_name(&self) -> &'static str {
+ // Forwards to the base state's panicking implementation; concrete commands supply
+ // their own class name through `impl_php_class!`.
+ self.inner.php_class_name()
}
}