aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/base_dependency_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
committernsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
commit6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 (patch)
treee39261f4aa7314fe8c75142670c76591cdaccb92 /crates/shirabe/src/command/base_dependency_command.rs
parent5d3232a80be4b989e89cc7ae4e3642cc5acae030 (diff)
downloadphp-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.gz
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.zst
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.zip
feat(console): resolve phase-b TODOs in doRun and IO wiring
Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/base_dependency_command.rs')
-rw-r--r--crates/shirabe/src/command/base_dependency_command.rs17
1 files changed, 8 insertions, 9 deletions
diff --git a/crates/shirabe/src/command/base_dependency_command.rs b/crates/shirabe/src/command/base_dependency_command.rs
index decfd5b..27f3544 100644
--- a/crates/shirabe/src/command/base_dependency_command.rs
+++ b/crates/shirabe/src/command/base_dependency_command.rs
@@ -40,9 +40,6 @@ pub trait BaseDependencyCommand: BaseCommand {
fn colors(&self) -> &[String];
fn colors_mut(&mut self) -> &mut Vec<String>;
- // TODO(phase-b): these wrappers existed to forward BaseCommand setters, but they
- // shadowed the BaseCommand methods and caused ambiguity. Use BaseCommand directly.
-
fn do_execute(
&mut self,
input: std::rc::Rc<std::cell::RefCell<dyn InputInterface>>,
@@ -153,12 +150,12 @@ pub trait BaseDependencyCommand: BaseCommand {
FindPackageConstraint::String(text_constraint.clone()),
)?;
if matched_package.is_none() {
+ let rm = composer.get_repository_manager();
let mut default_repos = CompositeRepository::new(
RepositoryFactory::default_repos(
Some(self.get_io()),
Some(composer.get_config()),
- // TODO(phase-b): get_repository_manager returns &; default_repos needs &mut
- Some(todo!("share repository_manager as &mut")),
+ Some(&mut rm.borrow_mut()),
)?
.into_values()
.collect(),
@@ -402,10 +399,12 @@ pub trait BaseDependencyCommand: BaseCommand {
"blue".to_string(),
];
for color in self.colors() {
- // TODO(phase-b): output.get_formatter() returns &OutputFormatter; set_style needs
- // &mut. Need interior mutability or `get_formatter_mut`.
- let _ = OutputFormatterStyle::new(Some(color), None, None);
- let _ = output.borrow().get_formatter();
+ let style = OutputFormatterStyle::new(Some(color), None, None);
+ output
+ .borrow()
+ .get_formatter()
+ .borrow_mut()
+ .set_style(color, style);
}
}