aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/base_dependency_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-06 02:13:59 +0900
committernsfisis <nsfisis@gmail.com>2026-06-06 02:13:59 +0900
commitcd25c3e193f05a5e89bca2a1c706c85fdc9c9155 (patch)
tree86971cac4e5011af0077416e6ca674c4251496ee /crates/shirabe/src/command/base_dependency_command.rs
parentb299a0c9b66523b9630b4cf6d3dca1509c3692b5 (diff)
downloadphp-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.gz
php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.zst
php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.zip
refactor(repository): make read methods fallible and take &mut self
Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/base_dependency_command.rs')
-rw-r--r--crates/shirabe/src/command/base_dependency_command.rs12
1 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/src/command/base_dependency_command.rs b/crates/shirabe/src/command/base_dependency_command.rs
index 177b0e6..5dfb13f 100644
--- a/crates/shirabe/src/command/base_dependency_command.rs
+++ b/crates/shirabe/src/command/base_dependency_command.rs
@@ -88,7 +88,7 @@ pub trait BaseDependencyCommand: BaseCommand {
let local_repo = repository_manager.get_local_repository();
let root_pkg = composer.get_package();
- if local_repo.get_packages().len() == 0
+ if local_repo.get_packages()?.len() == 0
&& (root_pkg.get_requires().len() > 0 || root_pkg.get_dev_requires().len() > 0)
{
output.writeln(
@@ -132,7 +132,7 @@ pub trait BaseDependencyCommand: BaseCommand {
"*".to_string()
};
- let packages = installed_repo.find_packages_with_replacers_and_providers(&needle, None);
+ let packages = installed_repo.find_packages_with_replacers_and_providers(&needle, None)?;
if packages.is_empty() {
return Err(anyhow::anyhow!(InvalidArgumentException {
message: format!("Could not find package \"{}\" in your project", needle),
@@ -143,9 +143,9 @@ pub trait BaseDependencyCommand: BaseCommand {
let matched_package = installed_repo.find_package(
&needle,
FindPackageConstraint::String(text_constraint.clone()),
- );
+ )?;
if matched_package.is_none() {
- let default_repos = CompositeRepository::new(
+ let mut default_repos = CompositeRepository::new(
RepositoryFactory::default_repos(
Some(self.get_io()),
Some(composer.get_config()),
@@ -158,7 +158,7 @@ pub trait BaseDependencyCommand: BaseCommand {
if let Some(r#match) = default_repos.find_package(
&needle,
FindPackageConstraint::String(text_constraint.clone()),
- ) {
+ )? {
installed_repo.add_repository(
crate::repository::RepositoryInterfaceHandle::new(
InstalledArrayRepository::new_with_packages(vec![
@@ -259,7 +259,7 @@ pub trait BaseDependencyCommand: BaseCommand {
inverted,
recursive,
None,
- );
+ )?;
if results.is_empty() {
let extra = if has_constraint {
format!(