diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
| commit | a9f19862350c6fd3592d93515d869ffe07ecb399 (patch) | |
| tree | 3d2e97403d658476e9e42a1d179cd29b606240e2 /crates/shirabe/src/command/create_project_command.rs | |
| parent | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (diff) | |
| download | php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.gz php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.zst php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.zip | |
feat: resolve trivial todo!() sites with existing constructors
Replace todo!("VersionParser::new()") with VersionParser::new() at 6
call sites (array_loader, base_command, create_project_command,
vcs_repository, http_downloader x2) and EventDispatcher::io_clone with
self.io.clone(). All targets already exist on their types.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/create_project_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/create_project_command.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crates/shirabe/src/command/create_project_command.rs b/crates/shirabe/src/command/create_project_command.rs index 90a4d99..efbfd44 100644 --- a/crates/shirabe/src/command/create_project_command.rs +++ b/crates/shirabe/src/command/create_project_command.rs @@ -567,8 +567,7 @@ impl CreateProjectCommand { no_progress: bool, secure_http: bool, ) -> Result<bool> { - // TODO(phase-b): VersionParser has no public `new` yet - let parser: VersionParser = todo!("VersionParser::new()"); + let parser: VersionParser = VersionParser::new(); let requirements = parser.parse_name_version_pairs(vec![package_name.to_string()])?; let name = strtolower( requirements[0] |