aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/diagnose_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 16:16:51 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 16:16:51 +0900
commit6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (patch)
treee0fc935abf0cebb2c557581fbfd098bdef35d558 /crates/shirabe/src/command/diagnose_command.rs
parent4361059d3bb27916179acfebb8889f1863319bb9 (diff)
downloadphp-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.gz
php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.zst
php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.zip
refactor(php-shim): introduce PhpClass for reporting PHP class names
Rust has no runtime class name, so `Command::get_class` existed purely to let each command hand back its PHP class name, supplied through the two-argument variant of `delegate_command_trait_impls_to_inner!` at the impl site. Replace it with a general `PhpClass` trait plus an `impl_php_class!` macro, so the name is stated once next to the type definition and the mechanism is reusable outside commands. `Command` gains `PhpClass` as a supertrait and drops `get_class`, and `VcsDriverKind`'s hand-rolled `php_class_name` table moves onto the trait. Behavior is unchanged: the same class-name strings are reported, and the base command state still panics when asked for a name it cannot supply. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/diagnose_command.rs')
-rw-r--r--crates/shirabe/src/command/diagnose_command.rs12
1 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs
index 047b8377..1674e10e 100644
--- a/crates/shirabe/src/command/diagnose_command.rs
+++ b/crates/shirabe/src/command/diagnose_command.rs
@@ -40,8 +40,9 @@ use shirabe_external_packages::symfony::console::output::OutputInterface;
use shirabe_external_packages::symfony::process::ExecutableFinder;
use shirabe_php_shim::{
InvalidArgumentException, PHP_EOL, PhpMixed, disk_free_space, file_exists, filter_var_boolean,
- get_class_err, hash, implode, is_array, is_string, php_regex, rtrim, str_contains, str_replace,
- str_starts_with, strpos, strstr, strstr3, strtolower, trim, version_compare,
+ get_class_err, hash, impl_php_class, implode, is_array, is_string, php_regex, rtrim,
+ str_contains, str_replace, str_starts_with, strpos, strstr, strstr3, strtolower, trim,
+ version_compare,
};
#[derive(Debug)]
@@ -55,6 +56,8 @@ pub struct DiagnoseCommand {
pub(crate) exit_code: std::cell::Cell<i64>,
}
+impl_php_class!(DiagnoseCommand, r"Composer\Command\DiagnoseCommand");
+
impl Default for DiagnoseCommand {
fn default() -> Self {
Self::new()
@@ -452,10 +455,7 @@ impl Command for DiagnoseCommand {
crate::command::base_command::base_command_complete(self, input, suggestions)
}
- shirabe_external_packages::delegate_command_trait_impls_to_inner!(
- base_command_data,
- "Composer\\Command\\DiagnoseCommand"
- );
+ shirabe_external_packages::delegate_command_trait_impls_to_inner!(base_command_data);
}
impl BaseCommand for DiagnoseCommand {