diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:55:46 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:55:46 +0900 |
| commit | 7f14217abbba2f89ae5845d63c8f97b606354f45 (patch) | |
| tree | a000f7297f8aff509b74ce25ff871b334bcfc191 /crates/shirabe/src/command/exec_command.rs | |
| parent | b151ceaa798a7d2e9b55ffbc4e4b10ea8f0a59a8 (diff) | |
| download | php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.tar.gz php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.tar.zst php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.zip | |
fix(io): widen IOInterface::select choices to PhpMixed for assoc arrays
PHP's IOInterface::select accepts an associative choices array whose keys
are the selectable values, but the port narrowed it to Vec<String>, making
key-based selection unrepresentable. Accept PhpMixed (List or Array) like
PHP's array $choices; ConsoleIO already branched on both shapes internally.
Also mirror PHP in the single-select array_search fallback for numeric-keyed
arrays. All call sites keep their previous list-based behavior.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/exec_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/exec_command.rs | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/crates/shirabe/src/command/exec_command.rs b/crates/shirabe/src/command/exec_command.rs index 3eaee5a9..057c9eb2 100644 --- a/crates/shirabe/src/command/exec_command.rs +++ b/crates/shirabe/src/command/exec_command.rs @@ -118,7 +118,12 @@ impl Command for ExecCommand { let io = self.get_io(); let binary = io.select( "Binary to run: ".to_string(), - binaries.clone(), + PhpMixed::List( + binaries + .iter() + .map(|b| PhpMixed::String(b.clone())) + .collect(), + ), PhpMixed::String(String::new()), PhpMixed::Int(1), "Invalid binary name \"%s\"".to_string(), |