diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:16:51 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:16:51 +0900 |
| commit | 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (patch) | |
| tree | e0fc935abf0cebb2c557581fbfd098bdef35d558 /crates/shirabe/src/command/global_command.rs | |
| parent | 4361059d3bb27916179acfebb8889f1863319bb9 (diff) | |
| download | php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.gz php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.tar.zst php-shirabe-6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5.zip | |
refactor(php-shim): introduce PhpClass for reporting PHP class names
Rust has no runtime class name, so `Command::get_class` existed purely to
let each command hand back its PHP class name, supplied through the
two-argument variant of `delegate_command_trait_impls_to_inner!` at the
impl site. Replace it with a general `PhpClass` trait plus an
`impl_php_class!` macro, so the name is stated once next to the type
definition and the mechanism is reusable outside commands.
`Command` gains `PhpClass` as a supertrait and drops `get_class`, and
`VcsDriverKind`'s hand-rolled `php_class_name` table moves onto the trait.
Behavior is unchanged: the same class-name strings are reported, and the
base command state still panics when asked for a name it cannot supply.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/global_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/global_command.rs | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/global_command.rs b/crates/shirabe/src/command/global_command.rs index 2795b778..79037e55 100644 --- a/crates/shirabe/src/command/global_command.rs +++ b/crates/shirabe/src/command/global_command.rs @@ -19,7 +19,7 @@ use shirabe_external_packages::symfony::console::input::ArrayInput; use shirabe_external_packages::symfony::console::input::InputInterface; use shirabe_external_packages::symfony::console::input::StringInput; use shirabe_external_packages::symfony::console::output::OutputInterface; -use shirabe_php_shim::{LogicException, RuntimeException, chdir, php_regex}; +use shirabe_php_shim::{LogicException, RuntimeException, chdir, impl_php_class, php_regex}; use std::path::Path; #[derive(Debug)] @@ -27,6 +27,8 @@ pub struct GlobalCommand { base_command_data: BaseCommandData, } +impl_php_class!(GlobalCommand, r"Composer\Command\GlobalCommand"); + impl Default for GlobalCommand { fn default() -> Self { Self::new() @@ -268,10 +270,7 @@ impl Command for GlobalCommand { base_command_initialize(self, input, output) } - shirabe_external_packages::delegate_command_trait_impls_to_inner!( - base_command_data, - "Composer\\Command\\GlobalCommand" - ); + shirabe_external_packages::delegate_command_trait_impls_to_inner!(base_command_data); } impl BaseCommand for GlobalCommand { |
