aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/init_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
commit5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch)
treec7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/src/command/init_command.rs
parentb291e714bc739262140323e08fe2fb9e91e00ee7 (diff)
downloadphp-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/init_command.rs')
-rw-r--r--crates/shirabe/src/command/init_command.rs25
1 files changed, 25 insertions, 0 deletions
diff --git a/crates/shirabe/src/command/init_command.rs b/crates/shirabe/src/command/init_command.rs
index 22cd75b..f63014c 100644
--- a/crates/shirabe/src/command/init_command.rs
+++ b/crates/shirabe/src/command/init_command.rs
@@ -1075,6 +1075,31 @@ impl InitCommand {
file_put_contents(ignore_file, format!("{}{}\n", contents, vendor).as_bytes());
}
+ /// For testing only: invoke the private `parse_author_string`.
+ pub fn __parse_author_string(&self, author: &str) -> Result<IndexMap<String, Option<String>>> {
+ self.parse_author_string(author)
+ }
+
+ /// For testing only: invoke the crate-private `format_authors`.
+ pub fn __format_authors(&self, author: &str) -> Result<Vec<IndexMap<String, PhpMixed>>> {
+ self.format_authors(author)
+ }
+
+ /// For testing only: invoke the crate-private `get_git_config`.
+ pub fn __get_git_config(&mut self) -> IndexMap<String, String> {
+ self.get_git_config()
+ }
+
+ /// For testing only: invoke the crate-private `has_vendor_ignore`.
+ pub fn __has_vendor_ignore(&self, ignore_file: &str, vendor: &str) -> bool {
+ self.has_vendor_ignore(ignore_file, vendor)
+ }
+
+ /// For testing only: invoke the crate-private `add_vendor_ignore`.
+ pub fn __add_vendor_ignore(&self, ignore_file: &str, vendor: &str) {
+ self.add_vendor_ignore(ignore_file, vendor)
+ }
+
pub(crate) fn is_valid_email(&self, email: &str) -> bool {
shirabe_php_shim::filter_var_email(email)
}