aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/licenses_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-26 01:55:03 +0900
committernsfisis <nsfisis@gmail.com>2026-06-26 01:55:03 +0900
commitcbb5118318706dc023eb8551b1f2628f395a6228 (patch)
tree35c86c3191c2bfdb154fdfae7ad6f3292c0261f8 /crates/shirabe/src/command/licenses_command.rs
parent939359f13acfe8dbf4f16dac517fcbd67d46f611 (diff)
downloadphp-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.tar.gz
php-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.tar.zst
php-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.zip
refactor(symfony-table): model rows/cells with enums instead of PhpMixed
The Table helper modeled a row's cells as PhpMixed and recovered the concrete TableCell/TableSeparator types via runtime instance_of, leaving the entire mixed/array bridge (to_row_vec, cell_colspan, row_get, ...) as todo!(). Replace that with proper Row/Cell enums: Row = HeaderDivider | Separator(TableSeparator) | Cells(Vec<Cell>) Cell = Null | Value(String) | Cell(TableCell) | Separator(TableSeparator) The internal header/body boundary that PHP detects by object identity ($divider === $row) becomes the dedicated Row::HeaderDivider variant. Style arguments (PHP string|TableStyle) become a StyleName enum, so Table::new no longer panics in resolve_style's instance_of stub; TableStyle derives Clone so named styles resolve from the registry. PhpMixed-based callers (SymfonyStyle::table, render_table, auditor's sanitize) bridge via From<PhpMixed> for Cell/Row at the boundary. Un-ignores LicensesCommandTest text-format cases (4) and BaseDependencyCommandTest::why; output matches PHP exactly. Removes ~15 impl todo!()s in the Table helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/licenses_command.rs')
-rw-r--r--crates/shirabe/src/command/licenses_command.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/licenses_command.rs b/crates/shirabe/src/command/licenses_command.rs
index 3be4df3..e8d62cc 100644
--- a/crates/shirabe/src/command/licenses_command.rs
+++ b/crates/shirabe/src/command/licenses_command.rs
@@ -200,11 +200,11 @@ impl Command for LicensesCommand {
io.write("");
let mut table = Table::new(output);
- table.set_style(shirabe_php_shim::PhpMixed::from("compact"))??;
+ table.set_style("compact".into())??;
table.set_headers(vec![
- PhpMixed::String("Name".to_string()),
- PhpMixed::String("Version".to_string()),
- PhpMixed::String("Licenses".to_string()),
+ "Name".into(),
+ "Version".into(),
+ "Licenses".into(),
]);
for package in &packages {
let link = PackageInfo::get_view_source_or_homepage_url(package.clone());
@@ -234,7 +234,7 @@ impl Command for LicensesCommand {
crate::package::DisplayMode::SourceRefIfDev,
)),
PhpMixed::String(licenses_str),
- ]));
+ ]).into());
}
table.render();
}