diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-25 23:25:25 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-25 23:25:25 +0900 |
| commit | 3c39377b0c419dd4cc792aef926032b15c12b69f (patch) | |
| tree | 59d10e9a13d71727ccee0b6356ad8dd5f6ddfb55 /crates/shirabe/src/command/package_discovery_trait.rs | |
| parent | 47b81add8dc5e8d53ed1c8507c2791d0dd6a5929 (diff) | |
| download | php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.tar.gz php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.tar.zst php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.zip | |
fix(package-discovery): pass IO so platform requirement warnings surface
findBestVersionForPackage is the only findBestCandidate() caller that PHP hands
$this->getIO() to; the port passed None, so VersionSelector silently skipped
every "Cannot use <pkg> as it requires <ext> which is missing from your
platform" warning. require/update/create-project therefore dropped a candidate
without telling the user why.
Un-ignores require_command_test::test_require, whose first data-provider case
asserts exactly that warning.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/package_discovery_trait.rs')
| -rw-r--r-- | crates/shirabe/src/command/package_discovery_trait.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/shirabe/src/command/package_discovery_trait.rs b/crates/shirabe/src/command/package_discovery_trait.rs index 52d0682c..8e34fed0 100644 --- a/crates/shirabe/src/command/package_discovery_trait.rs +++ b/crates/shirabe/src/command/package_discovery_trait.rs @@ -484,7 +484,7 @@ pub trait PackageDiscoveryTrait: BaseCommand { preferred_stability, Some(platform_requirement_filter.clone()), 0, - None, + Some(io.clone()), ShowWarnings::Always, )?; |