diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-06 02:13:59 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-06 02:13:59 +0900 |
| commit | cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 (patch) | |
| tree | 86971cac4e5011af0077416e6ca674c4251496ee /crates/shirabe/src/command/remove_command.rs | |
| parent | b299a0c9b66523b9630b4cf6d3dca1509c3692b5 (diff) | |
| download | php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.gz php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.zst php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.zip | |
refactor(repository): make read methods fallible and take &mut self
Change RepositoryInterface and WritableRepositoryInterface read methods
(find_package, find_packages, get_packages, load_packages, search,
get_providers, get_canonical_packages) to take &mut self and return
anyhow::Result, so lazy-loading repositories such as ComposerRepository
can perform fallible I/O and mutate internal state on access. Update all
implementors and call sites to propagate the Result and pass mutable
references.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/remove_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/remove_command.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/src/command/remove_command.rs b/crates/shirabe/src/command/remove_command.rs index faab5fe..225714e 100644 --- a/crates/shirabe/src/command/remove_command.rs +++ b/crates/shirabe/src/command/remove_command.rs @@ -22,6 +22,7 @@ use crate::json::JsonFile; use crate::package::BasePackage; use crate::package::base_package; use crate::repository::CanonicalPackagesTrait; +use crate::repository::RepositoryInterface; #[derive(Debug)] pub struct RemoveCommand { @@ -198,12 +199,11 @@ impl RemoveCommand { } } - let locked_packages = composer + let mut locked_repo = composer .get_locker() .borrow_mut() - .get_locked_repository(true)? - .borrow() - .get_packages(); + .get_locked_repository(true)?; + let locked_packages = locked_repo.borrow_mut().get_packages()?; let mut required: IndexMap<String, bool> = IndexMap::new(); for link in composer @@ -435,7 +435,7 @@ impl RemoveCommand { composer_opt .get_plugin_manager() .borrow_mut() - .deactivate_installed_plugins(); + .deactivate_installed_plugins()?; } self.reset_composer(); @@ -626,7 +626,7 @@ impl RemoveCommand { .get_repository_manager() .borrow() .get_local_repository() - .find_packages(package, None) + .find_packages(package, None)? .is_empty() { io.write_error(&format!( |
