aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/run_script_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 11:33:44 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 11:33:44 +0900
commitf1dee6362f9b25e78f7e6417e957c0ca34356ecb (patch)
treec25c07d81153b4fb12ae840db9c3eb71f5d7fab4 /crates/shirabe/src/command/run_script_command.rs
parent876f1bf158cf03944ba56fee351fa97b34fda9e0 (diff)
downloadphp-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.tar.gz
php-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.tar.zst
php-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.zip
feat(command): wire suggested values into every command definition
Ports the per-command completion metadata that PHP passes as the suggestedValues constructor argument, resolving all TODO(cli-completion) markers: - CompletionTrait providers on 18 argument/option sites (installed/root/ available package names, package types, prefer-install) - static value lists (--format on show/outdated/search/fund/licenses/ check-platform-reqs, archive's FORMATS, audit --ignore-severity, update --bump-after-update, repository's action list) - command-specific closures: ConfigCommand::suggest_setting_keys, ShowCommand::suggest_package_based_on_mode, RepositoryCommand's suggest_repo_names/suggest_type_for_add, exec/run-script inline closures (downcast from the this argument, as the closures are bound to their concrete command in PHP) - GlobalCommand::complete, delegating completion to the wrapped subcommand through CompletionInput::from_string - a complete() override on every Composer command forwarding to base_command_complete (BaseCommand inheritance restoration) Also fixes CompleteCommand to call merge_application_definition(true) as PHP's default-argument call does; with false the application-level "command" argument was missing from the bound definition, shifting every argument-position detection by one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/run_script_command.rs')
-rw-r--r--crates/shirabe/src/command/run_script_command.rs27
1 files changed, 25 insertions, 2 deletions
diff --git a/crates/shirabe/src/command/run_script_command.rs b/crates/shirabe/src/command/run_script_command.rs
index 1ac9e9a4..b041f146 100644
--- a/crates/shirabe/src/command/run_script_command.rs
+++ b/crates/shirabe/src/command/run_script_command.rs
@@ -118,12 +118,27 @@ impl Command for RunScriptCommand {
self.set_aliases(vec!["run".to_string()])?;
self.set_description("Runs the scripts defined in composer.json");
self.set_definition(&[
- // TODO(cli-completion): script-name completion was provided via a closure suggesting runtime script names
- InputArgument::new(
+ // PHP passes an inline closure here (it takes no arguments; PHP tolerates the
+ // extra ones the caller passes).
+ InputArgument::new5(
"script",
Some(InputArgument::OPTIONAL),
"Script name to run.",
None,
+ crate::console::input::SuggestedValues::Closure(Box::new(
+ |this, _input, _suggestions| {
+ let this = this
+ .as_any()
+ .downcast_ref::<RunScriptCommand>()
+ .expect("the script suggestions are bound to RunScriptCommand");
+ // PHP: array_map(fn ($script) => $script['name'], $this->getScripts())
+ Ok(this
+ .get_scripts()?
+ .into_iter()
+ .map(|(name, _description)| name)
+ .collect())
+ },
+ )),
)
.unwrap()
.into(),
@@ -330,6 +345,14 @@ impl Command for RunScriptCommand {
base_command_initialize(self, input, output)
}
+ fn complete(
+ &self,
+ input: &shirabe_external_packages::symfony::console::completion::completion_input::CompletionInput,
+ suggestions: &mut shirabe_external_packages::symfony::console::completion::completion_suggestions::CompletionSuggestions,
+ ) -> anyhow::Result<()> {
+ crate::command::base_command::base_command_complete(self, input, suggestions)
+ }
+
shirabe_external_packages::delegate_command_trait_impls_to_inner!(
base_command_data,
"Composer\\Command\\RunScriptCommand"