aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/show_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 11:33:44 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 11:33:44 +0900
commitf1dee6362f9b25e78f7e6417e957c0ca34356ecb (patch)
treec25c07d81153b4fb12ae840db9c3eb71f5d7fab4 /crates/shirabe/src/command/show_command.rs
parent876f1bf158cf03944ba56fee351fa97b34fda9e0 (diff)
downloadphp-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.tar.gz
php-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.tar.zst
php-shirabe-f1dee6362f9b25e78f7e6417e957c0ca34356ecb.zip
feat(command): wire suggested values into every command definition
Ports the per-command completion metadata that PHP passes as the suggestedValues constructor argument, resolving all TODO(cli-completion) markers: - CompletionTrait providers on 18 argument/option sites (installed/root/ available package names, package types, prefer-install) - static value lists (--format on show/outdated/search/fund/licenses/ check-platform-reqs, archive's FORMATS, audit --ignore-severity, update --bump-after-update, repository's action list) - command-specific closures: ConfigCommand::suggest_setting_keys, ShowCommand::suggest_package_based_on_mode, RepositoryCommand's suggest_repo_names/suggest_type_for_add, exec/run-script inline closures (downcast from the this argument, as the closures are bound to their concrete command in PHP) - GlobalCommand::complete, delegating completion to the wrapped subcommand through CompletionInput::from_string - a complete() override on every Composer command forwarding to base_command_complete (BaseCommand inheritance restoration) Also fixes CompleteCommand to call merge_application_definition(true) as PHP's default-argument call does; with false the application-level "command" argument was missing from the bound definition, shifting every argument-position detection by one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/show_command.rs')
-rw-r--r--crates/shirabe/src/command/show_command.rs44
1 files changed, 37 insertions, 7 deletions
diff --git a/crates/shirabe/src/command/show_command.rs b/crates/shirabe/src/command/show_command.rs
index c5116b80..55ec5ddf 100644
--- a/crates/shirabe/src/command/show_command.rs
+++ b/crates/shirabe/src/command/show_command.rs
@@ -1,10 +1,12 @@
//! ref: composer/src/Composer/Command/ShowCommand.php
+use crate::command::CompletionTrait;
use crate::command::base_command::base_command_initialize;
use crate::command::{BaseCommand, BaseCommandData};
use crate::composer::PartialComposerHandle;
use crate::console::input::InputArgument;
use crate::console::input::InputOption;
+use crate::console::input::SuggestedValues;
use crate::dependency_resolver::DefaultPolicy;
use crate::dependency_resolver::PolicyInterface;
use crate::filter::platform_requirement_filter::PlatformRequirementFilterInterface;
@@ -84,9 +86,6 @@ impl Command for ShowCommand {
self.set_name("show")?;
self.set_aliases(vec!["info".to_string()])?;
self.set_description("Shows information about packages");
- // TODO(cli-completion): the package/ignore suggestion closures (suggestPackageBasedOnMode /
- // suggestInstalledPackage) and the format option's allowed-value list are dropped, matching
- // the InputArgument/InputOption API which does not yet carry completion metadata.
let opt_none = |name: &str, shortcut: Option<&str>, description: &str| {
InputOption::new(
name,
@@ -99,11 +98,12 @@ impl Command for ShowCommand {
.into()
};
self.set_definition(&[
- InputArgument::new(
+ InputArgument::new5(
"package",
Some(InputArgument::OPTIONAL),
"Package to inspect. Or a name including a wildcard (*) to filter lists of packages instead.",
None,
+ self.suggest_package_based_on_mode(),
)
.unwrap()
.into(),
@@ -134,12 +134,13 @@ impl Command for ShowCommand {
Some("o"),
"Show the latest version but only for packages that are outdated",
),
- InputOption::new(
+ InputOption::new6(
"ignore",
None,
Some(InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY),
"Ignore specified package(s). Can contain wildcards (*). Use it with the --outdated option if you don't want to be informed about new versions of some packages.",
None,
+ self.suggest_installed_package(false, false),
)
.unwrap()
.into(),
@@ -173,12 +174,13 @@ impl Command for ShowCommand {
None,
"Return a non-zero exit code when there are outdated packages",
),
- InputOption::new(
+ InputOption::new6(
"format",
Some(PhpMixed::String("f".to_string())),
Some(InputOption::VALUE_REQUIRED),
"Format of the output: text or json",
Some(PhpMixed::String("text".to_string())),
+ SuggestedValues::List(vec!["json".to_string(), "text".to_string()]),
)
.unwrap()
.into(),
@@ -1441,6 +1443,14 @@ impl Command for ShowCommand {
base_command_initialize(self, input, output)
}
+ fn complete(
+ &self,
+ input: &shirabe_external_packages::symfony::console::completion::completion_input::CompletionInput,
+ suggestions: &mut shirabe_external_packages::symfony::console::completion::completion_suggestions::CompletionSuggestions,
+ ) -> anyhow::Result<()> {
+ crate::command::base_command::base_command_complete(self, input, suggestions)
+ }
+
shirabe_external_packages::delegate_command_trait_impls_to_inner!(
base_command_data,
"Composer\\Command\\ShowCommand"
@@ -1456,7 +1466,27 @@ impl BaseCommand for ShowCommand {
}
impl ShowCommand {
- // TODO(cli-completion): pub fn suggest_package_based_on_mode(&self) -> Box<dyn Fn(&CompletionInput) -> Vec<String>>
+ /// PHP: protected function suggestPackageBasedOnMode(): \Closure
+ pub(crate) fn suggest_package_based_on_mode(&self) -> crate::console::input::SuggestedValues {
+ crate::console::input::SuggestedValues::Closure(Box::new(|this, input, suggestions| {
+ if input.get_option("available")?.to_bool() || input.get_option("all")?.to_bool() {
+ return this.suggest_available_package_incl_platform().call(
+ this,
+ input,
+ suggestions,
+ );
+ }
+
+ if input.get_option("platform")?.to_bool() {
+ return this
+ .suggest_platform_package()
+ .call(this, input, suggestions);
+ }
+
+ this.suggest_installed_package(false, false)
+ .call(this, input, suggestions)
+ }))
+ }
#[allow(clippy::too_many_arguments, reason = "to keep PHP signature")]
fn print_packages(