diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:55:46 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:55:46 +0900 |
| commit | 7f14217abbba2f89ae5845d63c8f97b606354f45 (patch) | |
| tree | a000f7297f8aff509b74ce25ff871b334bcfc191 /crates/shirabe/src/command/update_command.rs | |
| parent | b151ceaa798a7d2e9b55ffbc4e4b10ea8f0a59a8 (diff) | |
| download | php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.tar.gz php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.tar.zst php-shirabe-7f14217abbba2f89ae5845d63c8f97b606354f45.zip | |
fix(io): widen IOInterface::select choices to PhpMixed for assoc arrays
PHP's IOInterface::select accepts an associative choices array whose keys
are the selectable values, but the port narrowed it to Vec<String>, making
key-based selection unrepresentable. Accept PhpMixed (List or Array) like
PHP's array $choices; ConsoleIO already branched on both shapes internally.
Also mirror PHP in the single-select array_search fallback for numeric-keyed
arrays. All call sites keep their previous list-based behavior.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/update_command.rs')
| -rw-r--r-- | crates/shirabe/src/command/update_command.rs | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/crates/shirabe/src/command/update_command.rs b/crates/shirabe/src/command/update_command.rs index b47c51d0..a20d288f 100644 --- a/crates/shirabe/src/command/update_command.rs +++ b/crates/shirabe/src/command/update_command.rs @@ -705,10 +705,12 @@ impl UpdateCommand { let select_result = io.select( "Select packages: (Select more than one value separated by comma) ".to_string(), - autocompleter_values - .keys() - .cloned() - .collect::<Vec<String>>(), + PhpMixed::List( + autocompleter_values + .keys() + .map(|k| PhpMixed::String(k.clone())) + .collect(), + ), PhpMixed::Bool(false), PhpMixed::Int(1), "No package named \"%s\" is installed.".to_string(), |