diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-22 21:37:17 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-22 21:37:17 +0900 |
| commit | 88b5c4b9c5f7941292b918b6eefe54947c4a0d96 (patch) | |
| tree | 2de6acb706d893f440e3afea1478faf9a0f680ca /crates/shirabe/src/command | |
| parent | 3185a4da1246bee5c564394a20874835b5d8def1 (diff) | |
| download | php-shirabe-88b5c4b9c5f7941292b918b6eefe54947c4a0d96.tar.gz php-shirabe-88b5c4b9c5f7941292b918b6eefe54947c4a0d96.tar.zst php-shirabe-88b5c4b9c5f7941292b918b6eefe54947c4a0d96.zip | |
chore(todo): tag or drop the TODO markers that carry no tag
`fund_command.rs` claimed `CompleteAliasPackage` still had to be handled,
but `as_complete()` resolves through `is_complete()`, which already covers
`CompleteAliasPackage` and `RootAliasPackage` — the same set PHP's
`instanceof CompletePackageInterface` matches. The preceding alias guard
rules those out anyway, so both markers went away; the first condition is
now a single chain, matching the shape of the PHP original.
`Application::find()` skips commands it cannot borrow, where Symfony
registers the aliases of every command unconditionally. That is a real
divergence, so it gets `TODO(port)`.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command')
| -rw-r--r-- | crates/shirabe/src/command/fund_command.rs | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/crates/shirabe/src/command/fund_command.rs b/crates/shirabe/src/command/fund_command.rs index 9511cc31..349decf9 100644 --- a/crates/shirabe/src/command/fund_command.rs +++ b/crates/shirabe/src/command/fund_command.rs @@ -135,16 +135,14 @@ impl Command for FundCommand { // collect funding data from default branches for (_, package) in &result.packages { - if package.as_alias().is_none() { - // TODO: check for CompleteAliasPackage as well - if let Some(complete_pkg) = package.as_complete() - && complete_pkg.is_default_branch() - && !complete_pkg.get_funding().is_empty() - && packages_to_load_names.contains(&complete_pkg.get_name()) - { - Self::insert_funding_data(&mut fundings, &complete_pkg)?; - packages_to_load_names.shift_remove(&complete_pkg.get_name()); - } + if package.as_alias().is_none() + && let Some(complete_pkg) = package.as_complete() + && complete_pkg.is_default_branch() + && !complete_pkg.get_funding().is_empty() + && packages_to_load_names.contains(&complete_pkg.get_name()) + { + Self::insert_funding_data(&mut fundings, &complete_pkg)?; + packages_to_load_names.shift_remove(&complete_pkg.get_name()); } } @@ -154,7 +152,6 @@ impl Command for FundCommand { { continue; } - // TODO: check for CompleteAliasPackage as well if let Some(complete_pkg) = package.as_complete() && !complete_pkg.get_funding().is_empty() { |
