diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-07 11:03:13 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-07 11:03:13 +0900 |
| commit | 3a6e69596d4f45ba1c50c6e932004e2160799d0c (patch) | |
| tree | 1f7175962e5c043b362fe3e82a46beb8fa2fbb40 /crates/shirabe/src/command | |
| parent | e1053c6881da1bba409a16783e01a89248507a66 (diff) | |
| download | php-shirabe-3a6e69596d4f45ba1c50c6e932004e2160799d0c.tar.gz php-shirabe-3a6e69596d4f45ba1c50c6e932004e2160799d0c.tar.zst php-shirabe-3a6e69596d4f45ba1c50c6e932004e2160799d0c.zip | |
feat(shirabe): resolve phase-b PhpMixed conversion TODOs
Implement self-contained call sites that wrap/unwrap PhpMixed without
touching shim bodies: platform-override and authentication IndexMap to
PhpMixed conversions, and dev-package-name / version-alias sorts via
usort with strcmp/strnatcmp. Drop stale TODO comments where the
PhpMixed unwrap was already inlined.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command')
| -rw-r--r-- | crates/shirabe/src/command/suggests_command.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/crates/shirabe/src/command/suggests_command.rs b/crates/shirabe/src/command/suggests_command.rs index d050ec7..223aa6c 100644 --- a/crates/shirabe/src/command/suggests_command.rs +++ b/crates/shirabe/src/command/suggests_command.rs @@ -54,13 +54,14 @@ impl SuggestsCommand { ))]; if composer.get_locker().borrow_mut().is_locked() { - // TODO(phase-b): get_platform_overrides returns IndexMap<String, String>; PlatformRepository::new expects IndexMap<String, PhpMixed> - let _platform_overrides = composer + let platform_overrides = composer .get_locker() .borrow_mut() .get_platform_overrides()?; - let platform_overrides: IndexMap<String, PhpMixed> = - todo!("convert IndexMap<String, String> to IndexMap<String, PhpMixed>"); + let platform_overrides: IndexMap<String, PhpMixed> = platform_overrides + .into_iter() + .map(|(k, v)| (k, PhpMixed::String(v))) + .collect(); installed_repos.push(RepositoryInterfaceHandle::new(PlatformRepository::new( vec![], platform_overrides, |