diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-26 02:31:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-26 02:31:34 +0900 |
| commit | 9d82f21a9a0a9392ac7577f4419a56fb94123ae6 (patch) | |
| tree | 8c81fd9b5765f33348283fdbcceb8ce51962699e /crates/shirabe/src/command | |
| parent | 8c4dc6cd48457f154eb067f296d79ef911573c91 (diff) | |
| download | php-shirabe-9d82f21a9a0a9392ac7577f4419a56fb94123ae6.tar.gz php-shirabe-9d82f21a9a0a9392ac7577f4419a56fb94123ae6.tar.zst php-shirabe-9d82f21a9a0a9392ac7577f4419a56fb94123ae6.zip | |
fix(remove-command,pool-builder): drop Composer re-entrancy and PRE_POOL_CREATE todo
RemoveCommand::execute held composer_full_mut across deactivate_installed_plugins
and event dispatch, both of which re-enter the same RefCell (composer.rs:500/446);
it only uses &self getters, so borrow it immutably.
PoolBuilder dispatched PluginEvents::PRE_POOL_CREATE by building an event that
required moving the (unclonable) repositories/Request — left as todo!(). The
event is purely plugin-facing and its result is never read in the no-plugin path
(Pool::new reads self.packages directly), so skip it with a TODO(plugin) note.
Removes the composer.rs re-entrancy and two todo!()s from the remove install
path; remove's tests now reach the unregistered-installers blocker (factory.rs).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command')
| -rw-r--r-- | crates/shirabe/src/command/remove_command.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/command/remove_command.rs b/crates/shirabe/src/command/remove_command.rs index d880ca0..c36c5dd 100644 --- a/crates/shirabe/src/command/remove_command.rs +++ b/crates/shirabe/src/command/remove_command.rs @@ -483,7 +483,7 @@ impl Command for RemoveCommand { // TODO(plugin): deactivate installed plugins if let Some(composer_opt) = self.try_composer(None, None) { - let mut composer_opt = crate::command::composer_full_mut(&composer_opt); + let composer_opt = crate::command::composer_full(&composer_opt); composer_opt .get_plugin_manager() .borrow_mut() @@ -492,7 +492,7 @@ impl Command for RemoveCommand { self.reset_composer(); let composer_handle = self.require_composer(None, None)?; - let mut composer = crate::command::composer_full_mut(&composer_handle); + let composer = crate::command::composer_full(&composer_handle); if dry_run { let root_package = composer.get_package(); |
