diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-07 13:37:11 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-07 13:37:11 +0900 |
| commit | 86961b16b2f5c9c26a776193934d13ff87ab7fea (patch) | |
| tree | 5a45b3aed39a6413e126c7992a8ac6ebcd30b0ad /crates/shirabe/src/config.rs | |
| parent | 14138dde4a8c874bdc498edd25d1a2d7dc9022be (diff) | |
| download | php-shirabe-86961b16b2f5c9c26a776193934d13ff87ab7fea.tar.gz php-shirabe-86961b16b2f5c9c26a776193934d13ff87ab7fea.tar.zst php-shirabe-86961b16b2f5c9c26a776193934d13ff87ab7fea.zip | |
refactor(phase-c): resolve shared-ownership TODOs via handle/Rc clones
Resolve the resolvable subset of category A (shared ownership / non-cloneable
PHP class) TODOs by leaning on values that are already shared behind Rc/handle
wrappers, where cloning preserves PHP reference semantics:
- solver: call IgnoreListPlatformRequirementFilter::filter_constraint with a
cloned AnyConstraint (a Clone enum) and propagate the Result
- update_command: filter PlatformRepository out of the repository manager's
handles into a CompositeRepository (array_filter equivalent)
- package_discovery_trait: pass the real platform_requirement_filter (Rc clone)
instead of substituting ignore_nothing()
- installation_manager: pass the original full operation list (Vec<Rc<_>>
clone) as all_operations
- file_downloader: swap self.io to NullIO and restore via std::mem::replace
- auditor: reuse the PackageInterfaceHandle list across the advisory and
abandoned-package queries
- process_executor: drop the unused, lossy Clone impl
- config / array_repository: demote settled RefCell-design markers to comments
Remaining category A items (factory installer wiring, purge_packages handle
bridge, installer cache identity, reinstall flow, plugin command discovery)
stay as TODOs since correct resolution needs structural refactors.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/config.rs')
| -rw-r--r-- | crates/shirabe/src/config.rs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/crates/shirabe/src/config.rs b/crates/shirabe/src/config.rs index 1cfb8cc..d1f0702 100644 --- a/crates/shirabe/src/config.rs +++ b/crates/shirabe/src/config.rs @@ -41,8 +41,6 @@ pub struct Config { warned_hosts: IndexMap<String, bool>, /// @var array<string, true> ssl_verify_warned_hosts: IndexMap<String, bool>, - /// @var array<string, string> - // TODO(phase-b): RefCell to allow `&self` access from Config::get / get_with_flags. source_of_config_value: RefCell<IndexMap<String, String>>, } |
