diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-12 03:19:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-12 03:19:34 +0900 |
| commit | efe5bdb1987411a473d4af15451a376d20928245 (patch) | |
| tree | 54d3c9e7ab92cfc7d7ec3d90ca3f29e828d929c4 /crates/shirabe/src/dependency_resolver/pool_builder.rs | |
| parent | 981cae63d9777b877aa9f96907c7995ec020fbf9 (diff) | |
| download | php-shirabe-efe5bdb1987411a473d4af15451a376d20928245.tar.gz php-shirabe-efe5bdb1987411a473d4af15451a376d20928245.tar.zst php-shirabe-efe5bdb1987411a473d4af15451a376d20928245.zip | |
refactor(php-shim): replace literal sprintf calls with format!
Convert every sprintf() call with a compile-time literal format string to
format!, implementing Display for PhpMixed (delegating to php_to_string) so
PhpMixed values render with PHP string semantics through {}. Also merge the
format!-wrapped and conditional-literal dynamic sites into single format!
calls. Genuinely runtime format strings (table styles, configurable error
messages, command synopsis, progress-bar modifiers, regex-built messages)
still go through sprintf.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/pool_builder.rs')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/pool_builder.rs | 36 |
1 files changed, 16 insertions, 20 deletions
diff --git a/crates/shirabe/src/dependency_resolver/pool_builder.rs b/crates/shirabe/src/dependency_resolver/pool_builder.rs index b96dc79..a517488 100644 --- a/crates/shirabe/src/dependency_resolver/pool_builder.rs +++ b/crates/shirabe/src/dependency_resolver/pool_builder.rs @@ -1086,21 +1086,19 @@ impl PoolBuilder { } self.io.write3( - &sprintf( - "Pool optimizer completed in %.3f seconds", - &[(microtime(true) - before).into()], + &format!( + "Pool optimizer completed in {:.3} seconds", + (microtime(true) - before), ), true, io_interface::VERY_VERBOSE, ); self.io.write3( - &sprintf( - "<info>Found %s package versions referenced in your dependency graph. %s (%d%%) were optimized away.</info>", - &[ - number_format(total, 0, ".", ",").into(), - number_format(filtered, 0, ".", ",").into(), - round(100.0 / total * filtered, 0).into(), - ], + &format!( + "<info>Found {} package versions referenced in your dependency graph. {} ({}%) were optimized away.</info>", + number_format(total, 0, ".", ","), + number_format(filtered, 0, ".", ","), + round(100.0 / total * filtered, 0), ), true, io_interface::VERY_VERBOSE, @@ -1138,21 +1136,19 @@ impl PoolBuilder { } self.io.write3( - &sprintf( - "Security advisory pool filter completed in %.3f seconds", - &[(microtime(true) - before).into()], + &format!( + "Security advisory pool filter completed in {:.3} seconds", + (microtime(true) - before), ), true, io_interface::VERY_VERBOSE, ); self.io.write3( - &sprintf( - "<info>Found %s package versions referenced in your dependency graph. %s (%d%%) were filtered away.</info>", - &[ - number_format(total, 0, ".", ",").into(), - number_format(filtered, 0, ".", ",").into(), - round(100.0 / total * filtered, 0).into(), - ], + &format!( + "<info>Found {} package versions referenced in your dependency graph. {} ({}%) were filtered away.</info>", + number_format(total, 0, ".", ","), + number_format(filtered, 0, ".", ","), + round(100.0 / total * filtered, 0), ), true, io_interface::VERY_VERBOSE, |