aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/dependency_resolver/pool_optimizer.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-06 04:22:46 +0900
committernsfisis <nsfisis@gmail.com>2026-08-06 04:23:22 +0900
commit3d4a0cadc950d4440251efa11b55b0bfb0afdef7 (patch)
treecf1cd680867b9aa633eafe6332b881711b738823 /crates/shirabe/src/dependency_resolver/pool_optimizer.rs
parentce6192f1cfaac63457b173f573ada661a4665bfb (diff)
downloadphp-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.tar.gz
php-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.tar.zst
php-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.zip
chore: drop @param/@return tags that only restate Rust types
The ported docblocks copied @param and @return straight from the PHP source. When such a tag carries nothing but a type and an argument name, the Rust signature already states it, so the line is noise. Tags whose text adds prose beyond the type are kept. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/pool_optimizer.rs')
-rw-r--r--crates/shirabe/src/dependency_resolver/pool_optimizer.rs7
1 files changed, 0 insertions, 7 deletions
diff --git a/crates/shirabe/src/dependency_resolver/pool_optimizer.rs b/crates/shirabe/src/dependency_resolver/pool_optimizer.rs
index 16013e34..972d2f21 100644
--- a/crates/shirabe/src/dependency_resolver/pool_optimizer.rs
+++ b/crates/shirabe/src/dependency_resolver/pool_optimizer.rs
@@ -423,8 +423,6 @@ impl PoolOptimizer {
self.packages_to_remove.insert(id, true);
}
- /// @param array<string, array<string, array<string, list<BasePackage>>>> $identicalDefinitionsPerPackage
- /// @param array<int, array<string, array{groupHash: string, dependencyHash: string}>> $packageIdenticalDefinitionLookup
fn keep_package(
&mut self,
package: BasePackageHandle,
@@ -626,8 +624,6 @@ impl PoolOptimizer {
/// Disjunctive require constraints need to be considered in their own group. E.g. "^2.14 || ^3.3" needs to generate
/// two require constraint groups in order for us to keep the best matching package for "^2.14" AND "^3.3" as otherwise, we'd
/// only keep either one which can cause trouble (e.g. when using --prefer-lowest).
- ///
- /// @return void
fn extract_require_constraints_per_package(
&mut self,
package: &str,
@@ -644,8 +640,6 @@ impl PoolOptimizer {
/// Disjunctive conflict constraints need to be considered in their own group. E.g. "^2.14 || ^3.3" needs to generate
/// two conflict constraint groups in order for us to keep the best matching package for "^2.14" AND "^3.3" as otherwise, we'd
/// only keep either one which can cause trouble (e.g. when using --prefer-lowest).
- ///
- /// @return void
fn extract_conflict_constraints_per_package(
&mut self,
package: &str,
@@ -659,7 +653,6 @@ impl PoolOptimizer {
}
}
- /// @return ConstraintInterface[]
fn expand_disjunctive_multi_constraints(
&self,
constraint: AnyConstraint,