diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-25 16:16:33 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-25 16:17:10 +0900 |
| commit | 432472808051cb4f1bb9517b858dbc810aaa5a63 (patch) | |
| tree | 4c58b97942853ea2c3f58368203fa93187746cf8 /crates/shirabe/src/dependency_resolver/problem.rs | |
| parent | d4608662f28b9a5135986b1702afe3199957eabe (diff) | |
| download | php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.gz php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.zst php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.zip | |
refactor: replace redundant clones with moves
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/problem.rs')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/problem.rs | 28 |
1 files changed, 7 insertions, 21 deletions
diff --git a/crates/shirabe/src/dependency_resolver/problem.rs b/crates/shirabe/src/dependency_resolver/problem.rs index a2072372..a944ff0c 100644 --- a/crates/shirabe/src/dependency_resolver/problem.rs +++ b/crates/shirabe/src/dependency_resolver/problem.rs @@ -634,12 +634,7 @@ impl Problem { .iter() .filter(|p| { root_reqs[package_name].matches( - &SimpleConstraint::new( - "==".to_string(), - p.get_version().to_string(), - None, - ) - .into(), + &SimpleConstraint::new("==".to_string(), p.get_version(), None).into(), ) }) .collect(); @@ -678,12 +673,8 @@ impl Problem { .iter() .filter(|p| { temp_reqs[&name].matches( - &SimpleConstraint::new( - "==".to_string(), - p.get_version().to_string(), - None, - ) - .into(), + &SimpleConstraint::new("==".to_string(), p.get_version(), None) + .into(), ) }) .collect(); @@ -719,19 +710,14 @@ impl Problem { if let Some(ref lp) = locked_package { let fixed_constraint = AnyConstraint::from(SimpleConstraint::new( "==".to_string(), - lp.get_version().to_string(), + lp.get_version(), None, )); let filtered: Vec<&BasePackageHandle> = packages .iter() .filter(|p| { fixed_constraint.matches( - &SimpleConstraint::new( - "==".to_string(), - p.get_version().to_string(), - None, - ) - .into(), + &SimpleConstraint::new("==".to_string(), p.get_version(), None).into(), ) }) .collect(); @@ -1080,7 +1066,7 @@ impl Problem { let entry = prepared .entry(pkg_name.clone()) .or_insert_with(|| PreparedEntry { - name: package.get_pretty_name().to_string(), + name: package.get_pretty_name(), versions: IndexMap::new(), }); entry.name = package.get_pretty_name().to_string(); @@ -1200,7 +1186,7 @@ impl Problem { } } - let mut version: String = selected.get_pretty_version().to_string(); + let mut version: String = selected.get_pretty_version(); let extra = selected.get_extra(); if selected.as_complete().is_some() && extra.contains_key("config.platform") |