aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/dependency_resolver/request.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-06 02:13:59 +0900
committernsfisis <nsfisis@gmail.com>2026-06-06 02:13:59 +0900
commitcd25c3e193f05a5e89bca2a1c706c85fdc9c9155 (patch)
tree86971cac4e5011af0077416e6ca674c4251496ee /crates/shirabe/src/dependency_resolver/request.rs
parentb299a0c9b66523b9630b4cf6d3dca1509c3692b5 (diff)
downloadphp-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.gz
php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.tar.zst
php-shirabe-cd25c3e193f05a5e89bca2a1c706c85fdc9c9155.zip
refactor(repository): make read methods fallible and take &mut self
Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/request.rs')
-rw-r--r--crates/shirabe/src/dependency_resolver/request.rs7
1 files changed, 4 insertions, 3 deletions
diff --git a/crates/shirabe/src/dependency_resolver/request.rs b/crates/shirabe/src/dependency_resolver/request.rs
index df26535..88957f2 100644
--- a/crates/shirabe/src/dependency_resolver/request.rs
+++ b/crates/shirabe/src/dependency_resolver/request.rs
@@ -195,11 +195,12 @@ impl Request {
pub fn get_present_map(
&self,
package_ids: bool,
- ) -> IndexMap<String, crate::package::BasePackageHandle> {
+ ) -> anyhow::Result<IndexMap<String, crate::package::BasePackageHandle>> {
let mut present_map: IndexMap<String, crate::package::BasePackageHandle> = IndexMap::new();
if let Some(ref locked_repository) = self.locked_repository {
- for package in RepositoryInterface::get_packages(&*locked_repository.borrow()) {
+ for package in RepositoryInterface::get_packages(&mut *locked_repository.borrow_mut())?
+ {
let key = if package_ids {
package.get_id().to_string()
} else {
@@ -218,7 +219,7 @@ impl Request {
present_map.insert(key, package.clone());
}
- present_map
+ Ok(present_map)
}
pub fn get_fixed_packages_map(&self) -> IndexMap<i64, BasePackageHandle> {