diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:51:45 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:51:45 +0900 |
| commit | a2110fa811c8f6c7d1c45a83c6fd1077eb6f3461 (patch) | |
| tree | 620f3cea4ef0c99b5e4a0b7878a59b9e7dbabe36 /crates/shirabe/src/dependency_resolver | |
| parent | 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (diff) | |
| download | php-shirabe-a2110fa811c8f6c7d1c45a83c6fd1077eb6f3461.tar.gz php-shirabe-a2110fa811c8f6c7d1c45a83c6fd1077eb6f3461.tar.zst php-shirabe-a2110fa811c8f6c7d1c45a83c6fd1077eb6f3461.zip | |
fix(php-shim): use PhpMixed::to_bool() for PHP truthy casts
Several call sites coerced PhpMixed to bool via `.as_bool()` (which
only matches a literal Bool variant) where the corresponding PHP code
does a plain `(bool)` cast or truthy check (isset()/array_key_exists()
+ implicit bool conversion). This silently dropped truthy non-bool
values (e.g. String("true"), String("1"), Int(1)) to their unwrap_or
default instead of PHP's actual truthy result. Switched these sites to
PhpMixed::to_bool(), which implements PHP's full truthy-cast rules.
Diffstat (limited to 'crates/shirabe/src/dependency_resolver')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/default_policy.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/dependency_resolver/default_policy.rs b/crates/shirabe/src/dependency_resolver/default_policy.rs index e7d02e24..24069466 100644 --- a/crates/shirabe/src/dependency_resolver/default_policy.rs +++ b/crates/shirabe/src/dependency_resolver/default_policy.rs @@ -6,6 +6,7 @@ use crate::package::BasePackageHandle; use crate::package::STABILITIES; use crate::util::Platform; use indexmap::IndexMap; +use shirabe_php_shim::PhpMixed; use shirabe_semver::CompilingMatcher; use shirabe_semver::constraint::SimpleConstraint; @@ -31,8 +32,7 @@ impl DefaultPolicy { prefer_lowest, preferred_versions, prefer_dev_over_prerelease: Platform::get_env("COMPOSER_PREFER_DEV_OVER_PRERELEASE") - .map(|v| !v.is_empty()) - .unwrap_or(false), + .is_some_and(|v| PhpMixed::String(v).to_bool()), preferred_package_result_cache_per_pool: std::cell::RefCell::new(IndexMap::new()), sorting_cache_per_pool: std::cell::RefCell::new(IndexMap::new()), } |
