diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-06 02:51:49 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-06 02:51:49 +0900 |
| commit | cccd901aef23a0ff7e9f87a4a57e9074c816a06f (patch) | |
| tree | 3929a3f165419d43e69154fdf173771fbcbb5fad /crates/shirabe/src/dependency_resolver | |
| parent | ad78317ecf8ffadae3088452b6b52e2d476fadeb (diff) | |
| download | php-shirabe-cccd901aef23a0ff7e9f87a4a57e9074c816a06f.tar.gz php-shirabe-cccd901aef23a0ff7e9f87a4a57e9074c816a06f.tar.zst php-shirabe-cccd901aef23a0ff7e9f87a4a57e9074c816a06f.zip | |
fix(command): use full pretty version and drop stale phase-b TODOs
LicensesCommand now renders the root package version via
get_full_pretty_version, matching PHP getFullPrettyVersion, and holds
the root package handle directly instead of snapshotting fields. Also
align update/mark-alias operations on get_full_pretty_version and remove
the now-stale phase-b TODO markers in status and licenses commands.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver')
3 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/src/dependency_resolver/operation/mark_alias_installed_operation.rs b/crates/shirabe/src/dependency_resolver/operation/mark_alias_installed_operation.rs index 4ef436b..f5cb825 100644 --- a/crates/shirabe/src/dependency_resolver/operation/mark_alias_installed_operation.rs +++ b/crates/shirabe/src/dependency_resolver/operation/mark_alias_installed_operation.rs @@ -41,7 +41,7 @@ impl OperationInterface for MarkAliasInstalledOperation { self.package.get_alias_of().get_pretty_name(), self.package .get_alias_of() - .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev,), + .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev), ) } diff --git a/crates/shirabe/src/dependency_resolver/operation/mark_alias_uninstalled_operation.rs b/crates/shirabe/src/dependency_resolver/operation/mark_alias_uninstalled_operation.rs index 41b0979..f8314f5 100644 --- a/crates/shirabe/src/dependency_resolver/operation/mark_alias_uninstalled_operation.rs +++ b/crates/shirabe/src/dependency_resolver/operation/mark_alias_uninstalled_operation.rs @@ -41,7 +41,7 @@ impl OperationInterface for MarkAliasUninstalledOperation { self.package.get_alias_of().get_pretty_name(), self.package .get_alias_of() - .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev,), + .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev), ) } diff --git a/crates/shirabe/src/dependency_resolver/operation/update_operation.rs b/crates/shirabe/src/dependency_resolver/operation/update_operation.rs index 104f4ef..0bf3e35 100644 --- a/crates/shirabe/src/dependency_resolver/operation/update_operation.rs +++ b/crates/shirabe/src/dependency_resolver/operation/update_operation.rs @@ -32,10 +32,10 @@ impl UpdateOperation { target_package: PackageInterfaceHandle, lock: bool, ) -> String { - let mut from_version = - initial_package.get_full_pretty_version(false, crate::package::DisplayMode::SourceRef); - let mut to_version = - target_package.get_full_pretty_version(false, crate::package::DisplayMode::SourceRef); + let mut from_version = initial_package + .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev); + let mut to_version = target_package + .get_full_pretty_version(true, crate::package::DisplayMode::SourceRefIfDev); if from_version == to_version && initial_package.get_source_reference() != target_package.get_source_reference() |