aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/downloader/svn_downloader.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-23 03:07:15 +0900
committernsfisis <nsfisis@gmail.com>2026-05-23 15:48:00 +0900
commite068a9d644fde6659a88accd55b3f1d0d9d7cf46 (patch)
treebb719a70eb8c840957a94a5601df8961055ceb0f /crates/shirabe/src/downloader/svn_downloader.rs
parent60eb89529c8af2e4477e0bb65ed9e0f2dc7d3dd7 (diff)
downloadphp-shirabe-e068a9d644fde6659a88accd55b3f1d0d9d7cf46.tar.gz
php-shirabe-e068a9d644fde6659a88accd55b3f1d0d9d7cf46.tar.zst
php-shirabe-e068a9d644fde6659a88accd55b3f1d0d9d7cf46.zip
refactor(promise): rewrite promise bodies to async/await
Mechanically convert promise-returning function bodies to async/await: resolve() returns the value directly, forwarding calls get .await, and simple .then chains become await sequences. Also collapse the installer double-Option (Result<Option<Option<PhpMixed>>> -> Result<Option<PhpMixed>>). Hard spots that depend on the Loop::wait / job-machine boundary (accept/reject orchestration, closures capturing &mut self, batch waits) are left intact and marked with TODO(phase-c-promise) for manual porting. The crate does not compile yet; traits still need #[async_trait]. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/downloader/svn_downloader.rs')
-rw-r--r--crates/shirabe/src/downloader/svn_downloader.rs18
1 files changed, 9 insertions, 9 deletions
diff --git a/crates/shirabe/src/downloader/svn_downloader.rs b/crates/shirabe/src/downloader/svn_downloader.rs
index 65e3e37..f3d0fef 100644
--- a/crates/shirabe/src/downloader/svn_downloader.rs
+++ b/crates/shirabe/src/downloader/svn_downloader.rs
@@ -57,7 +57,7 @@ impl SvnDownloader {
.into());
}
- Ok(promise::resolve(None))
+ Ok(None)
}
pub(crate) async fn do_install(
@@ -101,7 +101,7 @@ impl SvnDownloader {
Some(path),
)?;
- Ok(promise::resolve(None))
+ Ok(None)
}
pub(crate) async fn do_update(
@@ -152,7 +152,7 @@ impl SvnDownloader {
None,
)?;
- Ok(promise::resolve(None))
+ Ok(None)
}
pub fn get_local_changes(&self, package: &dyn PackageInterface, path: &str) -> Option<String> {
@@ -210,7 +210,7 @@ impl SvnDownloader {
) -> anyhow::Result<Option<PhpMixed>> {
let changes = self.get_local_changes(package, path);
if changes.is_none() {
- return Ok(promise::resolve(None));
+ return Ok(None);
}
if !self.inner.io.is_interactive() {
@@ -222,10 +222,10 @@ impl SvnDownloader {
.as_bool()
== Some(true)
{
- return self.discard_changes(path);
+ return self.discard_changes(path).await;
}
- return self.inner.clean_changes(package, path, update);
+ return self.inner.clean_changes(package, path, update).await;
}
let changes_str = changes.unwrap();
@@ -273,7 +273,7 @@ impl SvnDownloader {
.as_string()
{
Some("y") => {
- self.discard_changes(path)?;
+ self.discard_changes(path).await?;
break;
}
Some("n") => {
@@ -310,7 +310,7 @@ impl SvnDownloader {
}
}
- Ok(promise::resolve(None))
+ Ok(None)
}
pub(crate) fn get_commit_logs(
@@ -421,7 +421,7 @@ impl SvnDownloader {
.into());
}
- Ok(promise::resolve(None))
+ Ok(None)
}
pub(crate) fn has_metadata_repository(&self, path: &str) -> bool {