diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:41:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:46:18 +0900 |
| commit | 2d474e91e49c7343d28198eff2b5bbbed9afbcee (patch) | |
| tree | 8c1ab321dfa5ddc1ca9d2871eb06a6fde6b2970b /crates/shirabe/src/event_dispatcher | |
| parent | e583112899cbea7494ffdd73d7de380dd5f808c4 (diff) | |
| download | php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.gz php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.zst php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.zip | |
feat(phase-c): resolve cross-module phase-b TODOs
Diffstat (limited to 'crates/shirabe/src/event_dispatcher')
| -rw-r--r-- | crates/shirabe/src/event_dispatcher/event_dispatcher.rs | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs index a9da6e8..729979d 100644 --- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs +++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs @@ -1067,8 +1067,6 @@ impl EventDispatcher { let package = composer.get_package(); let scripts = package.get_scripts(); - // TODO(phase-b): RootPackage::get_scripts() returns Vec<String> per event; - // mirror PHP's is_empty_value semantics on the Vec form. let event_scripts: Vec<String> = match scripts.get(event.get_name()) { Some(v) if !v.is_empty() => v.clone(), _ => return Vec::new(), @@ -1271,12 +1269,10 @@ impl EventDispatcher { package.clone(), packages, )?; - // TODO(phase-b): parse_autoloads also expects the filtered dev packages list - // (PhpMixed in this port). let map = generator.parse_autoloads( package_map, package.clone(), - shirabe_php_shim::PhpMixed::Null, + shirabe_php_shim::PhpMixed::Bool(false), ); if self.loader.is_some() { |
