aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/event_dispatcher
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
committernsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
commit6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 (patch)
treee39261f4aa7314fe8c75142670c76591cdaccb92 /crates/shirabe/src/event_dispatcher
parent5d3232a80be4b989e89cc7ae4e3642cc5acae030 (diff)
downloadphp-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.gz
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.zst
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.zip
feat(console): resolve phase-b TODOs in doRun and IO wiring
Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/event_dispatcher')
-rw-r--r--crates/shirabe/src/event_dispatcher/event_dispatcher.rs7
1 files changed, 4 insertions, 3 deletions
diff --git a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
index 729979d..2124093 100644
--- a/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
+++ b/crates/shirabe/src/event_dispatcher/event_dispatcher.rs
@@ -267,10 +267,11 @@ impl EventDispatcher {
}
// other newly appeared prepended autoloaders should be appended instead to ensure Composer loads its classes first
+ // PHP: spl_autoload_unregister($cb); spl_autoload_register($cb, true, $prepend);
// TODO(plugin): ClassLoader detection via instanceof — currently treat all callbacks uniformly
- // TODO(phase-b): `cb` is a PhpMixed; spl_autoload_*/register expect a typed
- // Box<dyn Fn(&str) -> PhpMixed + Send + Sync> callback. Bridging requires
- // exposing the underlying callable from PhpMixed.
+ // TODO(phase-c): `cb` is a PhpMixed holding a callable; spl_autoload_register/unregister
+ // (php-shims that stay todo!()) need a typed Box<dyn Fn(&str) -> PhpMixed> callback.
+ // Bridging requires the callable model to expose the underlying closure from PhpMixed.
let _ = &cb;
let _ = spl_autoload_unregister;
let _ = spl_autoload_register;