diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-07 18:26:55 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-07 18:28:13 +0900 |
| commit | b8a50e25aafb51a6d73f9695362854cc5ed58117 (patch) | |
| tree | abe43c770cbf652a5e723c6f9a37e9406c5dd52e /crates/shirabe/src/factory.rs | |
| parent | da6f05c12d08ac96b4286664cd8205d3fee042d8 (diff) | |
| download | php-shirabe-b8a50e25aafb51a6d73f9695362854cc5ed58117.tar.gz php-shirabe-b8a50e25aafb51a6d73f9695362854cc5ed58117.tar.zst php-shirabe-b8a50e25aafb51a6d73f9695362854cc5ed58117.zip | |
feat(phase-c): resolve &mut-access phase-b TODOs via handle setters
PHP mutator methods that the Phase B port could not call because only
&self / &dyn / Rc access was available. Resolved by the interior-mutation
APIs that already exist: handle &self setters (set_dist/source_reference,
set_requires/dev/references/stability_flags), Rc<RefCell<dyn InputInterface>>
.borrow_mut(), and get_installation_manager().borrow_mut() (build_package_map
passes an empty/canonical package list per upstream). composer.get_package()
returns &RootPackageInterfaceHandle, so the "&dyn" Phase B note was wrong.
factory's set_config_source/set_auth_config_source were already live code;
their stale TODOs are removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/factory.rs')
| -rw-r--r-- | crates/shirabe/src/factory.rs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/crates/shirabe/src/factory.rs b/crates/shirabe/src/factory.rs index c099777..ac7c055 100644 --- a/crates/shirabe/src/factory.rs +++ b/crates/shirabe/src/factory.rs @@ -289,7 +289,6 @@ impl Factory { let file_path_owned = file.get_path().to_string(); config.merge(&read_data, &file_path_owned); } - // TODO(phase-b): set_config_source takes Box<dyn ConfigSourceInterface> config.set_config_source(Box::new(JsonConfigSource::new( std::rc::Rc::new(std::cell::RefCell::new(file)), false, @@ -355,7 +354,6 @@ impl Factory { let auth_path_owned = auth_file.get_path().to_string(); config.merge(&wrapped, &auth_path_owned); } - // TODO(phase-b): set_auth_config_source takes Box<dyn ConfigSourceInterface> config.set_auth_config_source(Box::new(JsonConfigSource::new( std::rc::Rc::new(std::cell::RefCell::new(auth_file)), true, |