fix(array-dumper): emit package links and require Link pretty constraint

Resolve the phase-b TODO that left the supported-link-types loop as dead
code (links were always an empty Vec), so requires/conflicts/provides/
replaces/require-dev are dumped again via
PackageInterface::get_links_for_type, matching the PHP magic-call loop.

Every Link in production is constructed with a pretty constraint (all
ArrayLoader/AliasPackage/PlatformRepository/InstalledRepository sites
pass one), so make Link::pretty_constraint a required String instead of
Option<String>. get_pretty_constraint() now returns &str directly rather
than anyhow::Result<&str>, dropping the unreachable
UnexpectedValueException guard, and all call sites are updated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/crates/shirabe/src/installer.rs b/crates/shirabe/src/installer.rs
index 3ab88c2..2783364 100644
--- a/crates/shirabe/src/installer.rs
+++ b/crates/shirabe/src/installer.rs
@@ -1582,9 +1582,7 @@ impl Installer {
             if PlatformRepository::is_platform_package(link.get_target()) {
                 platform_reqs.insert(
                     link.get_target().to_string(),
-                    link.get_pretty_constraint()
-                        .map(|s| s.to_string())
-                        .unwrap_or_default(),
+                    link.get_pretty_constraint().to_string(),
                 );
             }
         }