diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-27 08:44:57 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-27 08:44:57 +0900 |
| commit | 901878ee3f2bee6605b02d321cc4c92bc32fd5b0 (patch) | |
| tree | 83d8c8c9a24cb95c0656866d328b87c2d4c5127f /crates/shirabe/src/installer/installation_manager.rs | |
| parent | 5c2c72223cb6b4d77a332eeeeff7ee4e82e3f239 (diff) | |
| download | php-shirabe-901878ee3f2bee6605b02d321cc4c92bc32fd5b0.tar.gz php-shirabe-901878ee3f2bee6605b02d321cc4c92bc32fd5b0.tar.zst php-shirabe-901878ee3f2bee6605b02d321cc4c92bc32fd5b0.zip | |
refactor(composer): hold managers behind *Interface traits
Composer/PartialComposer exposed its RepositoryManager, InstallationManager,
EventDispatcher, Locker, DownloadManager, AutoloadGenerator and ArchiveManager
as concrete types, but Composer's public setters (setDownloadManager() etc.)
let plugins swap in subclasses. Introduce a *Interface trait per manager and
store each as Rc<RefCell<dyn ...Interface>> so a replacement is honored.
Only Composer's slots and the sinks fed from its accessors become trait
objects; managers injected concretely at construction keep their concrete
references, matching PHP semantics. Fluent setters on the affected classes now
return () and Locker::update_hash is de-generified to a boxed FnOnce so the
traits stay object-safe.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/installer/installation_manager.rs')
| -rw-r--r-- | crates/shirabe/src/installer/installation_manager.rs | 75 |
1 files changed, 75 insertions, 0 deletions
diff --git a/crates/shirabe/src/installer/installation_manager.rs b/crates/shirabe/src/installer/installation_manager.rs index ac5f8e4..bee14cc 100644 --- a/crates/shirabe/src/installer/installation_manager.rs +++ b/crates/shirabe/src/installer/installation_manager.rs @@ -791,3 +791,78 @@ impl InstallationManager { } } } + +// Composer's PartialComposer::setInstallationManager() accepts any InstallationManager subclass, so +// plugins may swap in a replacement. The interface captures the methods reached through Composer's +// accessor and through the `&mut dyn InstallationManagerInterface` references fed from it. +pub trait InstallationManagerInterface: std::fmt::Debug { + fn add_installer(&mut self, installer: Box<dyn InstallerInterface>); + fn remove_installer(&mut self, installer: &dyn InstallerInterface); + fn disable_plugins(&mut self); + fn is_package_installed( + &mut self, + repo: &dyn InstalledRepositoryInterface, + package: PackageInterfaceHandle, + ) -> Result<bool>; + fn ensure_binaries_presence(&mut self, package: PackageInterfaceHandle); + fn execute( + &mut self, + repo: &mut dyn InstalledRepositoryInterface, + operations: Vec<std::rc::Rc<dyn OperationInterface>>, + dev_mode: bool, + run_scripts: bool, + download_only: bool, + ) -> Result<()>; + fn get_install_path(&mut self, package: PackageInterfaceHandle) -> Option<String>; + fn set_output_progress(&mut self, output_progress: bool); + fn notify_installs(&mut self, io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>); +} + +impl InstallationManagerInterface for InstallationManager { + fn add_installer(&mut self, installer: Box<dyn InstallerInterface>) { + self.add_installer(installer); + } + + fn remove_installer(&mut self, installer: &dyn InstallerInterface) { + self.remove_installer(installer); + } + + fn disable_plugins(&mut self) { + self.disable_plugins(); + } + + fn is_package_installed( + &mut self, + repo: &dyn InstalledRepositoryInterface, + package: PackageInterfaceHandle, + ) -> Result<bool> { + self.is_package_installed(repo, package) + } + + fn ensure_binaries_presence(&mut self, package: PackageInterfaceHandle) { + self.ensure_binaries_presence(package); + } + + fn execute( + &mut self, + repo: &mut dyn InstalledRepositoryInterface, + operations: Vec<std::rc::Rc<dyn OperationInterface>>, + dev_mode: bool, + run_scripts: bool, + download_only: bool, + ) -> Result<()> { + self.execute(repo, operations, dev_mode, run_scripts, download_only) + } + + fn get_install_path(&mut self, package: PackageInterfaceHandle) -> Option<String> { + self.get_install_path(package) + } + + fn set_output_progress(&mut self, output_progress: bool) { + self.set_output_progress(output_progress); + } + + fn notify_installs(&mut self, io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>>) { + self.notify_installs(io); + } +} |
