diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-20 03:44:17 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-20 13:22:55 +0900 |
| commit | fc39608de4226286c34aed0c0803edd15a8623a8 (patch) | |
| tree | b166d1cdbc603538e34a0ec0bb68b13da7795195 /crates/shirabe/src/installer/installer_interface.rs | |
| parent | 1afc35c977eb443967fc768d67057a28b56ba15b (diff) | |
| download | php-shirabe-fc39608de4226286c34aed0c0803edd15a8623a8.tar.gz php-shirabe-fc39608de4226286c34aed0c0803edd15a8623a8.tar.zst php-shirabe-fc39608de4226286c34aed0c0803edd15a8623a8.zip | |
refactor(installation-manager): cache installers by index, drop clone_box
InstallationManager::get_installer cached a per-type installer via a
Rust-only `clone_box` stub (`todo!()`). PHP caches the SAME instance
held in `$this->installers`. Store the index into `installers` instead,
reproducing that sharing without cloning; both `add_installer` and
`remove_installer` clear the cache, so indices never dangle. With the
only caller gone, `InstallerInterface::clone_box` is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/installer/installer_interface.rs')
| -rw-r--r-- | crates/shirabe/src/installer/installer_interface.rs | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/crates/shirabe/src/installer/installer_interface.rs b/crates/shirabe/src/installer/installer_interface.rs index 6df00c6..ff7708f 100644 --- a/crates/shirabe/src/installer/installer_interface.rs +++ b/crates/shirabe/src/installer/installer_interface.rs @@ -64,8 +64,4 @@ pub trait InstallerInterface: std::fmt::Debug { fn as_plugin_installer_mut(&mut self) -> Option<&mut PluginInstaller> { None } - - fn clone_box(&self) -> Box<dyn InstallerInterface> { - todo!() - } } |