aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/io.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-12 01:28:29 +0900
committernsfisis <nsfisis@gmail.com>2026-07-16 01:02:47 +0900
commitda751367b50ec4c680aa5f45d3ce0d192d647dbb (patch)
treee4c49be2b2e9f2bb84e08187949f6a681d8005c7 /crates/shirabe/src/io.rs
parent4d9e3dd6176a0cd2cc5e158b044beeb7b3de21be (diff)
downloadphp-shirabe-da751367b50ec4c680aa5f45d3ce0d192d647dbb.tar.gz
php-shirabe-da751367b50ec4c680aa5f45d3ce0d192d647dbb.tar.zst
php-shirabe-da751367b50ec4c680aa5f45d3ce0d192d647dbb.zip
test(downloader): record TODO(phase-d) reasons and port two git-downloader tests
zip/git/file downloader tests that were already #[ignore]d for a documented reason lacked the required in-body // TODO(phase-d) comment; record it for each. Two git_downloader_test.rs cases, test_download_uses_various_protocols_and_sets_push_url_for_github and test_update_doesnt_throws_runtime_exception_if_git_command_fails_at_first_but_is_able_to_recover, had been left as todo!() with a TODO(phase-d) claiming ComposerMirror::process_git_url's github regex lacks PCRE delimiters and panics. That regex already has delimiters and does not panic (verified directly), and other tests in this same file already use Package::set_source_mirrors to give a real package a mirror-prefixed getSourceUrls() list, so the stated blocker no longer applies. Port both tests using that existing technique instead of recording a TODO(phase-d) for them. No other test logic changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/io.rs')
0 files changed, 0 insertions, 0 deletions