aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/json
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 00:59:54 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 01:03:45 +0900
commit3a388b98a9aa6a14b1c7f7dc909c109cf9837800 (patch)
tree593e342313c6e6bd3ec2943a1690b8798e0a83ae /crates/shirabe/src/json
parentaad468e8b75ffc3e87ea6dfa22c53a8299fc08da (diff)
downloadphp-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.gz
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.tar.zst
php-shirabe-3a388b98a9aa6a14b1c7f7dc909c109cf9837800.zip
refactor: narrow pub(crate) items to private
Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/json')
-rw-r--r--crates/shirabe/src/json/json_file.rs2
-rw-r--r--crates/shirabe/src/json/json_manipulator.rs2
-rw-r--r--crates/shirabe/src/json/json_validation_exception.rs2
3 files changed, 3 insertions, 3 deletions
diff --git a/crates/shirabe/src/json/json_file.rs b/crates/shirabe/src/json/json_file.rs
index 652f1d89..78ed76d7 100644
--- a/crates/shirabe/src/json/json_file.rs
+++ b/crates/shirabe/src/json/json_file.rs
@@ -516,7 +516,7 @@ impl JsonFile {
/// @throws \UnexpectedValueException
/// @throws ParsingException
/// @return bool true on success
- pub(crate) fn validate_syntax(json: &str, file: Option<&str>) -> anyhow::Result<bool> {
+ fn validate_syntax(json: &str, file: Option<&str>) -> anyhow::Result<bool> {
// TODO(php-semantics): make json_decode() returns an error object with details.
let error = match serde_json::from_str::<serde_json::Value>(json) {
Ok(_) => {
diff --git a/crates/shirabe/src/json/json_manipulator.rs b/crates/shirabe/src/json/json_manipulator.rs
index 2fa4fe8f..766137ca 100644
--- a/crates/shirabe/src/json/json_manipulator.rs
+++ b/crates/shirabe/src/json/json_manipulator.rs
@@ -1546,7 +1546,7 @@ impl JsonManipulator {
JsonFile::encode(&data)
}
- pub(crate) fn detect_indenting(&mut self) {
+ fn detect_indenting(&mut self) {
self.indent = JsonFile::detect_indenting(Some(&self.contents));
}
}
diff --git a/crates/shirabe/src/json/json_validation_exception.rs b/crates/shirabe/src/json/json_validation_exception.rs
index cb7370d2..27661e38 100644
--- a/crates/shirabe/src/json/json_validation_exception.rs
+++ b/crates/shirabe/src/json/json_validation_exception.rs
@@ -5,7 +5,7 @@ use shirabe_php_shim::Exception;
#[derive(Debug)]
pub struct JsonValidationException {
inner: Exception,
- pub(crate) errors: Vec<String>,
+ errors: Vec<String>,
}
impl JsonValidationException {