diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 08:13:12 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 08:13:12 +0900 |
| commit | 087865ef50283350a3cc74a5363ba44fa7dbe5c5 (patch) | |
| tree | b27ded5001c46feb587839771347389f609a7c57 /crates/shirabe/src/lib.rs | |
| parent | a9dc11a1a0d8d442ab85b3eeb8791f2a8069d528 (diff) | |
| download | php-shirabe-087865ef50283350a3cc74a5363ba44fa7dbe5c5.tar.gz php-shirabe-087865ef50283350a3cc74a5363ba44fa7dbe5c5.tar.zst php-shirabe-087865ef50283350a3cc74a5363ba44fa7dbe5c5.zip | |
feat(php-rpc): implement phpinfo() capture over RPC
DiagnoseCommand::check_platform needed phpinfo() output but
shirabe-php-shim's ob_start()/phpinfo()/ob_get_clean() are unmodeled
todo!()s. Add a phpinfo dispatch entry to the PHP worker (capturing
output the same way extension_info already does) and a get_phpinfo()
wrapper, then switch check_platform to call it directly.
This unblocks the phpinfo-related panic in diagnose; the ignored
tests now hit a separate RefCell double-borrow bug in check_http, so
their ignore reasons are updated to point at that instead.
Diffstat (limited to 'crates/shirabe/src/lib.rs')
| -rw-r--r-- | crates/shirabe/src/lib.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crates/shirabe/src/lib.rs b/crates/shirabe/src/lib.rs index b5e58d08..4d17f6c6 100644 --- a/crates/shirabe/src/lib.rs +++ b/crates/shirabe/src/lib.rs @@ -182,10 +182,10 @@ mod cli_tests { run_config => "config", run_create_project => "create-project", run_depends => "depends", - #[ignore = "DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), \ - which are todo!() in shirabe-php-shim (PHP output buffering and runtime \ - introspection are unmodeled), so the command panics; same root cause as \ - tests/command/diagnose_command_test.rs"] + #[ignore = "DiagnoseCommand::check_http passes &config.borrow() into a call chain that \ + reaches CurlDownloader::download, which then does self.config.borrow_mut() on \ + the same Config RefCell, panicking with 'RefCell already borrowed'; same root \ + cause as tests/command/diagnose_command_test.rs"] run_diagnose => "diagnose", run_dump_autoload => "dump-autoload", run_exec => "exec", |
